Skip to content

Add fix for Start-Job initialization script in system lockdown #8284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 2 commits into from
Nov 26, 2018
Merged

Add fix for Start-Job initialization script in system lockdown #8284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aebe0d0
Add fix for Start-Job initialization script in system lockdown
PaulHigin Nov 15, 2018
36b09d0
[Feature]
PaulHigin Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,9 @@ private PSDataCollection<PSObject> InvokeScript(Command cmdToRun, RunspaceCreate
{
Debug.Assert(cmdToRun != null, "cmdToRun shouldn't be null");

cmdToRun.CommandOrigin = CommandOrigin.Internal;
// Don't invoke initialization script as trusted (CommandOrigin == Internal) if the system is in lock down mode.
cmdToRun.CommandOrigin = (SystemPolicy.GetSystemLockdownPolicy() == SystemEnforcementMode.Enforce) ? CommandOrigin.Runspace : CommandOrigin.Internal;

cmdToRun.MergeMyResults(PipelineResultTypes.Error, PipelineResultTypes.Output);
PowerShell powershell = PowerShell.Create();
powershell.AddCommand(cmdToRun).AddCommand("out-default");
Expand Down
22 changes: 22 additions & 0 deletions .../powershell/Modules/Microsoft.PowerShell.Security/ConstrainedLanguageValidation.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,28 @@ try
}
}

Describe "Start-Job initialization script should work in system lock down" -Tags 'Feature','RequireAdminOnWindows' {

It "Verifies that Start-Job initialization script runs successfully in system lock down" {

try
{
Invoke-LanguageModeTestingSupportCmdlet -SetLockdownMode
$ExecutionContext.SessionState.LanguageMode = "ConstrainedLanguage"

$job = Start-Job -InitializationScript { function Hello { "Hello" } } -ScriptBlock { Hello }
$result = $job | Wait-Job | Receive-Job
}
finally
{
Invoke-LanguageModeTestingSupportCmdlet -RevertLockdownMode -EnableFullLanguageMode
}

$result | Should -BeExactly "Hello"
$job | Remove-Job
}
}

# End Describe blocks
}
finally
Expand Down