Skip to content

Token calculation fix for Get-Help executed on ScriptBlock. - #8238

Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
hubuk:issue8234
Nov 20, 2018
Merged

Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
hubuk:issue8234

Conversation

@hubuk

@hubuk Hubert Bukowski (hubuk) commented Nov 12, 2018 •

Copy link
Copy Markdown
Contributor

Fix for #8234

PR Summary

Changed token calculation for Get-Help cmdlet.
Added test case for function dynamically created from script block.

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 16, 2018
@adityapatwardhan

Copy link
Copy Markdown
Member

Hubert Bukowski (@hubuk) I have pushed a commit with [Feature] tag according to https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr

The new test is part of a Describe which is marked as Feature. Hence, this was required.

@hubuk

Copy link
Copy Markdown
Contributor Author

Thanks, I can add [Feature] prefix to the message in my commit. Would you like me to do it instead and rebase my commit?

@adityapatwardhan

Copy link
Copy Markdown
Member

Hubert Bukowski (@hubuk) Don't worry about rebasing. I pushed an empty commit with [Feature] and we usually squash and merge.

I have restarted the CI on AppVeyor to pick up the fixes for the unrelated failing test.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit a8627b8 into PowerShell:master Nov 20, 2018
@adityapatwardhan

Copy link
Copy Markdown
Member

Hubert Bukowski (@hubuk) Thank you for your contribution!

@hubuk
Hubert Bukowski (hubuk) deleted the issue8234 branch November 20, 2018 23:21
Ilya (iSazonov) pushed a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants