Skip to content

Token calculation fix for Get-Help executed on ScriptBlock. #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 2 commits into from
Nov 20, 2018
Merged

Token calculation fix for Get-Help executed on ScriptBlock. #8238

adityapatwardhan merged 2 commits into from
Nov 20, 2018

Conversation

@hubuk
Copy link
Contributor

@hubuk hubuk commented Nov 12, 2018 •
edited by adityapatwardhan
Loading

Fix for #8234

PR Summary

Changed token calculation for Get-Help cmdlet.
Added test case for function dynamically created from script block.

PR Checklist

@adityapatwardhan adityapatwardhan self-assigned this Nov 12, 2018
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 16, 2018
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Nov 19, 2018

@hubuk I have pushed a commit with [Feature] tag according to https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr

The new test is part of a Describe which is marked as Feature. Hence, this was required.

@hubuk
Copy link
Contributor Author

hubuk commented Nov 20, 2018

Thanks, I can add [Feature] prefix to the message in my commit. Would you like me to do it instead and rebase my commit?

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Nov 20, 2018

@hubuk Don't worry about rebasing. I pushed an empty commit with [Feature] and we usually squash and merge.

I have restarted the CI on AppVeyor to pick up the fixes for the unrelated failing test.

@adityapatwardhan adityapatwardhan merged commit a8627b8 into PowerShell:master Nov 20, 2018
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Nov 20, 2018

@hubuk Thank you for your contribution!

@hubuk hubuk deleted the issue8234 branch November 20, 2018 23:21
iSazonov pushed a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
@hubuk @iSazonov
Token calculation fix for Get-Help executed on ScriptBlock for commen…
8001d70 
…t help. (PowerShell#8238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@Francisco-Gamino Francisco-Gamino Awaiting requested review from Francisco-Gamino

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hubuk @adityapatwardhan @iSazonov