Make install-powershell.sh autodetect if it should use wget or curl
#8225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarwinJS
requested review from
PaulHigin,
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
TravisEz13
changed the title
TravisEz13
changed the title
install-powershell.sh autodetect if it should use wget or curl
Member
|
I added a CI definition and filters to only run it if affected files are changed. I ran it here https://dev.azure.com/tplunk/powershell/_build/results?buildId=337&view=logs and it passed. @bmanikm Can you review? |
PaulHigin
reviewed
Nov 14, 2018
PaulHigin
approved these changes
Nov 14, 2018
TravisEz13
force-pushed
the
install-powershell-add-curl-wget-detection-issue-7872
branch
from
87c00f2 to
9353138
Compare
Member
|
rebased PR to hopefully fix unrelated test issues |
bmanikm
approved these changes
Nov 14, 2018
adityapatwardhan
added
the
CL-BuildPackaging
Member
|
@TravisEz13 Reminder to add CL-XXX labels. |
DarwinJS
deleted the
install-powershell-add-curl-wget-detection-issue-7872
branch
iSazonov
pushed a commit
to iSazonov/PowerShell
that referenced
this pull request
Nov 29, 2018
…url` (PowerShell#8225) install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests