Skip to content

Make install-powershell.sh autodetect if it should use wget or curl - #8225

Merged
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
DarwinJS:install-powershell-add-curl-wget-detection-issue-7872
Nov 14, 2018
Merged

Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
DarwinJS:install-powershell-add-curl-wget-detection-issue-7872

Conversation

@DarwinJS

Copy link
Copy Markdown
Contributor

PR Summary

install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.

PR Checklist

@TravisEz13 Travis Plunk (TravisEz13) changed the title Install powershell adding curl wget autodetection detection issue #7872 Install powershell adding curl wget autodetection detection issue Nov 13, 2018
@TravisEz13 Travis Plunk (TravisEz13) changed the title Install powershell adding curl wget autodetection detection issue Make install-powershell.sh autodetect if it should use wget or curl Nov 13, 2018
@TravisEz13

Copy link
Copy Markdown
Member

I added a CI definition and filters to only run it if affected files are changed. I ran it here https://dev.azure.com/tplunk/powershell/_build/results?buildId=337&view=logs and it passed. Manikyam Bavandla (@bmanikm) Can you review?

@TravisEz13
Travis Plunk (TravisEz13) force-pushed the install-powershell-add-curl-wget-detection-issue-7872 branch from 87c00f2 to 9353138 Compare November 14, 2018 02:27
@TravisEz13

Copy link
Copy Markdown
Member

rebased PR to hopefully fix unrelated test issues

@TravisEz13
Travis Plunk (TravisEz13) merged commit a244c04 into PowerShell:master Nov 14, 2018
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 15, 2018
@adityapatwardhan

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) Reminder to add CL-XXX labels.

@DarwinJS
Darwin (DarwinJS) deleted the install-powershell-add-curl-wget-detection-issue-7872 branch November 16, 2018 22:27
Ilya (iSazonov) pushed a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
…url` (PowerShell#8225)

install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
…url` (PowerShell#8225)

install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants