-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix tests running in Azure DevOps #8220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adityapatwardhan
merged 10 commits into
PowerShell:master
from
PaulHigin:RemoteTestExperiments
Nov 9, 2018
Merged
Fix tests running in Azure DevOps #8220
adityapatwardhan
merged 10 commits into
PowerShell:master
from
PaulHigin:RemoteTestExperiments
Nov 9, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
Nov 9, 2018
test/powershell/Modules/Microsoft.PowerShell.Management/Start-Process.Tests.ps1
Show resolved
Hide resolved
test/powershell/engine/Remoting/ImplicitRemotingBatching.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/engine/Remoting/ImplicitRemotingBatching.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/engine/Remoting/ImplicitRemotingBatching.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Nov 9, 2018
adityapatwardhan
approved these changes
Nov 9, 2018
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This change fixes tests that were failing when run in Azure DevOps. Most issues were due to the tests running as non-elevated, and the solution was to add the "RequireAdminOnWindows" tag.
This is especially true for remoting tests, where I updated the HelpersRemoting module to create a new remote session, runspace, or invoke-command against a PSCore6 (rather than WindowsPowerShell) endpoint. If the endpoint doesn't exist then it is created. Creating endpoints and connecting to endpoints require elevated privileges, so I made all remoting tests use the "RequireAdminOnWindows" tag.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests