Skip to content

Conversation

@PaulHigin
Copy link
Contributor

PR Summary

This change fixes tests that were failing when run in Azure DevOps. Most issues were due to the tests running as non-elevated, and the solution was to add the "RequireAdminOnWindows" tag.

This is especially true for remoting tests, where I updated the HelpersRemoting module to create a new remote session, runspace, or invoke-command against a PSCore6 (rather than WindowsPowerShell) endpoint. If the endpoint doesn't exist then it is created. Creating endpoints and connecting to endpoints require elevated privileges, so I made all remoting tests use the "RequireAdminOnWindows" tag.

PR Checklist

@adityapatwardhan adityapatwardhan merged commit d4bf5c8 into PowerShell:master Nov 9, 2018
@PaulHigin PaulHigin deleted the RemoteTestExperiments branch November 12, 2018 16:29
@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants