-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Adding verbose output for experimental implicit remoting batching feature #8166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adityapatwardhan
merged 7 commits into
PowerShell:master
from
PaulHigin:UpdateImplicitRemotingBatching
Nov 5, 2018
Merged
Adding verbose output for experimental implicit remoting batching feature #8166
adityapatwardhan
merged 7 commits into
PowerShell:master
from
PaulHigin:UpdateImplicitRemotingBatching
Nov 5, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@SteveL-MSFT Can you review this change? |
SteveL-MSFT
requested changes
Nov 1, 2018
SteveL-MSFT
approved these changes
Nov 1, 2018
iSazonov
reviewed
Nov 2, 2018
Member
|
The CI seems to be stuck. I will close and re-open the PR for restarting it. |
adityapatwardhan
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This change adds verbose output to the experimental implicit remoting batching feature, that provides information about whether the command line was batch-able for implicit remoting. If it is not batch-able then the reason why is provided. This is intended to help learn why a pipeline could not be batched and help address batching scenarios that should be covered.
Example:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests