Skip to content

Fix test for -WorkingDirectory when $PROFILE doesn't exist #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 1 commit into from
Oct 31, 2018
Merged

Fix test for -WorkingDirectory when $PROFILE doesn't exist #8152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions test/powershell/Host/ConsoleHost.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,13 @@ foo

It "-WorkingDirectory should be processed before profiles" {

$currentProfile = Get-Content $PROFILE
if (Test-Path $PROFILE) {
$currentProfile = Get-Content $PROFILE
}
else {
New-Item -ItemType File -Path $PROFILE -Force
Copy link
Member

@adityapatwardhan adityapatwardhan Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
New-Item -ItemType File -Path $PROFILE -Force
$null = New-Item -ItemType File -Path $PROFILE -Force

Copy link
Member

@adityapatwardhan adityapatwardhan Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as this comment is non-blocking.

Copy link
Collaborator

@vexx32 vexx32 Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
New-Item -ItemType File -Path $PROFILE -Force
New-Item -ItemType File -Path $PROFILE -Force > $null

😉

}

@"
(Get-Location).Path
Set-Location $testdrive
Expand All @@ -596,7 +602,12 @@ foo
$out[1] | Should -BeExactly "$testdrive"
}
finally {
Set-Content $PROFILE -Value $currentProfile
if ($currentProfile) {
Set-Content $PROFILE -Value $currentProfile
}
else {
Remove-Item $PROFILE
}
}
}
}
Expand Down