Error message enhancement for clear-content cmdlet when targeting a directory #8134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Oct 27, 2018
| if (Directory.Exists(path)) | ||
| { | ||
| throw PSTraceSource.NewNotSupportedException(SessionStateStrings.ClearDirectoryContent, path); | ||
| } |
Collaborator
There was a problem hiding this comment.
I'd expect non-terminating error.
/cc @mklement0
Member
There was a problem hiding this comment.
Yes, this should be non-terminating error.
Member
There was a problem hiding this comment.
Also, the check should be in the FileSystemProvider in this function:
not in the engine.
SteveL-MSFT
requested changes
Oct 28, 2018
| if (Directory.Exists(path)) | ||
| { | ||
| throw PSTraceSource.NewNotSupportedException(SessionStateStrings.ClearDirectoryContent, path); | ||
| } |
Member
There was a problem hiding this comment.
Yes, this should be non-terminating error.
SteveL-MSFT
requested changes
Oct 28, 2018
| if (Directory.Exists(path)) | ||
| { | ||
| throw PSTraceSource.NewNotSupportedException(SessionStateStrings.ClearDirectoryContent, path); | ||
| } |
Member
There was a problem hiding this comment.
Also, the check should be in the FileSystemProvider in this function:
not in the engine.
SteveL-MSFT
requested changes
Oct 28, 2018
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/resources/SessionStateStrings.resx
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/Clear-Content.Tests.ps1
Outdated
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Oct 29, 2018
Member
SteveL-MSFT
left a comment
SteveL-MSFT
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
anmenaga
approved these changes
Oct 29, 2018
src/System.Management.Automation/resources/SessionStateStrings.resx
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Oct 30, 2018
Collaborator
|
@kvprasoon Please add empty commit with "[Feature]" in header to run full test set. |
iSazonov
approved these changes
Nov 1, 2018
iSazonov
added
the
CL-General
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Error message enhancement for clear-content cmdlet when targeting a directory
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests