Skip to content

When using Start-Transcript and file exists, empty file rather than deleting #8131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Nov 7, 2018
Merged

When using Start-Transcript and file exists, empty file rather than deleting #8131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ba78ae
Avoid file deletion in Start-Transcript when not appending
paalbra Oct 26, 2018
a5c12d4
Use the built-in type alias 'string' rather than String or System.Str…
paalbra Oct 26, 2018
64e2b82
Add file deletion test in Start-Transcript.Tests
paalbra Nov 3, 2018
5e31313
Wrap Start-Transcript part in try-catch-finally in Start-Transcript.T…
paalbra Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ protected override void BeginProcessing()
}
}

// If they didn't specify -Append, delete the file
// If they didn't specify -Append, empty the file
if (!_shouldAppend)
{
System.IO.File.Delete(effectiveFilePath);
System.IO.File.WriteAllText(effectiveFilePath, string.Empty);
}
}

Expand Down
21 changes: 21 additions & 0 deletions test/powershell/Modules/Microsoft.Powershell.Host/Start-Transcript.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,27 @@ Describe "Start-Transcript, Stop-Transcript tests" -tags "CI" {
$expectedError = "CannotStartTranscription,Microsoft.PowerShell.Commands.StartTranscriptCommand"
ValidateTranscription -scriptToExecute $script -outputFilePath $null -expectedError $expectedError
}
It "Should not delete the file if it already exist" {
# Create an existing file
$transcriptFilePath = Join-Path $TestDrive ([System.IO.Path]::GetRandomFileName())
Out-File $transcriptFilePath

$FileSystemWatcher = [System.IO.FileSystemWatcher]::new((Split-Path -Parent $transcriptFilePath), (Split-Path -Leaf $transcriptFilePath))

$Job = Register-ObjectEvent -InputObject $FileSystemWatcher -EventName "Deleted" -SourceIdentifier "FileDeleted" -Action {
return "FileDeleted"
}

try {
Start-Transcript -Path $transcriptFilePath
Stop-Transcript
} finally {
Unregister-Event -SourceIdentifier "FileDeleted"
}

# Nothing should have been returned by the FileSystemWatcher
Receive-Job $job | Should -Be $null
}
It "Transcription should remain active if other runspace in the host get closed" {
try {
$ps = [powershell]::Create()
Expand Down