Enable case-insensitive tab completion for files and folders on case-sensitive filesystem #8128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
force-pushed
the
case-insensitive-completion
branch
from
ce88cb6 to
c59c3f9
Compare
SteveL-MSFT
force-pushed
the
case-insensitive-completion
branch
from
c59c3f9 to
5db5590
Compare
iSazonov
reviewed
Oct 26, 2018
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| It "Test case insensitive folder path" -Skip:(!$IsLinux) { | ||
| $testDirs = "AA", "Aa", "aa" |
Collaborator
There was a problem hiding this comment.
We could check dirs in previous test with files.
SteveL-MSFT
force-pushed
the
case-insensitive-completion
branch
from
8c4c313 to
07b18e4
Compare
iSazonov
approved these changes
Oct 26, 2018
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
force-pushed
the
case-insensitive-completion
branch
from
7377e03 to
a5b5889
Compare
iSazonov
reviewed
Oct 27, 2018
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
Co-Authored-By: SteveL-MSFT <slee@microsoft.com>
iSazonov
approved these changes
Oct 28, 2018
Collaborator
|
@SteveL-MSFT Should we close #1273? |
iSazonov
added
the
CL-General
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Leverage new EnumerationOption in .NET Core 2.1 to have case-insensitive enumeration of files and folders. Allows for case-insensitive tab completion of files and folders on a case-sensitive filesystem.
#1273
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests