Filter the TestPackage artifact upload by name to avoid other zip files being uploaded #8116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested review from
PaulHigin,
TravisEz13,
anmenaga and
daxian-dbw
as code owners
Member
Author
|
I have verified the changes on a private CI run, which is a clone of the official Azure DevOps pipeline. |
anmenaga
approved these changes
Oct 25, 2018
anmenaga
left a comment
anmenaga
left a comment
There was a problem hiding this comment.
1 update needed; otherwise looks good.
.vsts-ci/mac.yml
Outdated
| # Uploads any packages as an artifact | ||
| - powershell: | | ||
| Get-ChildItem -Path *.pkg, *.tar.gz, *.zip -Recurse | Select-Object -ExpandProperty FullName | ForEach-Object { | ||
| Write-Host "PWD == $pwd" |
There was a problem hiding this comment.
As far as I remember $pwd variable should Not be used in scripts. Change to Get-Location.
Collaborator
There was a problem hiding this comment.
it's likely in this context it's ok, but something that we should be aware of.
JamesWTruher
approved these changes
Oct 25, 2018
Collaborator
JamesWTruher
left a comment
JamesWTruher
left a comment
There was a problem hiding this comment.
my comment isn't blocking
.vsts-ci/mac.yml
Outdated
| # Uploads any packages as an artifact | ||
| - powershell: | | ||
| Get-ChildItem -Path *.pkg, *.tar.gz, *.zip -Recurse | Select-Object -ExpandProperty FullName | ForEach-Object { | ||
| Write-Host "PWD == $pwd" |
Collaborator
There was a problem hiding this comment.
it's likely in this context it's ok, but something that we should be aware of.
Member
Author
|
@JamesWTruher @anmenaga Removed the usage of |
Member
Author
|
I will merge when CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added logging for
New-TestPackageto make debugging easier.Filter the artifact uploads with the package name instead of *.zip to avoid Help Zip files from being uploaded.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests