Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Oct 24, 2018

PR Summary

There is specific code that sets the OutputFormat to xml if pwsh is run non-interactive, with redirected output, and the command was encoded. However, it ignored whether OutputFormat was specified. Fix is to track whether -OutputFormat was used and respect that value rather than defaulting to xml.

Fix #5912

PR Checklist

@SteveL-MSFT SteveL-MSFT added Breaking-Change breaking change that may affect users Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Oct 24, 2018
honor outputformat if specified in noninteractive, redirected, encoded command case
@SteveL-MSFT
Copy link
Member Author

@PowerShell/powershell-committee agrees we should honor the user supplied -OutputFormat and accept this breaking change

@SteveL-MSFT SteveL-MSFT added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Oct 24, 2018
@TravisEz13 TravisEz13 merged commit 1aa5bb3 into PowerShell:master Oct 30, 2018
@SteveL-MSFT SteveL-MSFT deleted the console-outputformat branch March 10, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change breaking change that may affect users Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pwsh ignores -OutputFormat text when writing to a redirected stderr stream

2 participants