Enable Set-Location -LiteralPath to work with folders named "-" and "+" #8089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested review from
adityapatwardhan and
daxian-dbw
as code owners
bergmeister
approved these changes
Oct 20, 2018
Contributor
bergmeister
left a comment
bergmeister
left a comment
There was a problem hiding this comment.
LGTM, thanks for quickly taking on this task.
iSazonov
reviewed
Oct 20, 2018
src/System.Management.Automation/engine/SessionStateLocationAPIs.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/SessionStateLocationAPIs.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/SessionStateLocationAPIs.cs
Outdated
Show resolved
Hide resolved
…Is.cs Co-Authored-By: SteveL-MSFT <slee@microsoft.com>
…Is.cs Co-Authored-By: SteveL-MSFT <slee@microsoft.com>
iSazonov
reviewed
Oct 21, 2018
Collaborator
There was a problem hiding this comment.
Not for the PR. Should this work too?
Set-Location -Path `+
Member
Author
There was a problem hiding this comment.
Escaping happens outside of this PR and this will continue to work
iSazonov
approved these changes
Oct 21, 2018
anmenaga
approved these changes
Oct 23, 2018
anmenaga
left a comment
anmenaga
left a comment
There was a problem hiding this comment.
It would be good to have a [feature] test pass for this.
SteveL-MSFT
force-pushed
the
set-location-literalpath
branch
from
d62c671 to
39165c8
Compare
iSazonov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
#7206 added the ability to use
cd -andcd +to navigate through location history. However, it prevented navigating to folders literally named "-" and "+". The internalsetlocation()api doesn't differentiate literal and non-literal paths so fix is to overload it with a flag to indicate path is literal so it doesn't process "-" and "+" as shortcuts.Fix #8086
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests