-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Added updated photo of VScode due to new version of VScode #8084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anmenaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New photo was taken on a high-res screen, so when auto-scaled to the low-width boundaries of 'using-vscode.md' tutorial it will be unreadable.
For taking the screenshot please: 1) temporary drop the resolution of the screen 2) make sure that VS code window is relatively square (currently proposed image is twice as wide as it is tall).
PS. While you are at it, it would be great if you could double-check 'Editing with Visual Studio Code' instructions on 'using-vscode.md'. Are they still accurate on the latest VS Code version? Thanks.
|
Hi Andrew,
Thank you for your feedback.
I have replaced the photo, which make the scaling better.
It’s currently 1920x1080, which is more “square”. And by using the Preview function, I can see it fits the window.
Also, I went through the ‘using-vscode.md’, and I can confirm that it is still updated and relevant.
Best regards,
Lasse Hastrup
Fra: Andrew <notifications@github.com>
Sendt: Monday, October 22, 2018 10:37 PM
Til: PowerShell/PowerShell <PowerShell@noreply.github.com>
Cc: Lasse Hastrup <l@hastrup.me>; Author <author@noreply.github.com>
Emne: Re: [PowerShell/PowerShell] Added updated photo of VScode due to new version of VScode (#8084)
@anmenaga requested changes on this pull request.
New photo was taken on a high-res screen, so when auto-scaled to the low-width boundaries of 'using-vscode.md' tutorial it will be unreadable.
For taking the screenshot please: 1) temporary drop the resolution of the screen 2) make sure that VS code window is relatively square (currently proposed image is twice as wide as it is tall).
PS. While you are at it, it would be great if you could double-check 'Editing with Visual Studio Code' instructions on 'using-vscode.md'. Are they still accurate on the latest VS Code version? Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#8084 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ap--SN1OLxmrzrw12w85wBSWlME3wRU9ks5uniyIgaJpZM4XwOwb>.
|
PR Summary
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests