Skip to content

Use DefaultPathSeparator char instead of DefaultPathSeparatorString #8082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 5 commits into from
Oct 31, 2018
Merged

Use DefaultPathSeparator char instead of DefaultPathSeparatorString #8082

iSazonov merged 5 commits into from
Oct 31, 2018

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Oct 19, 2018 •
edited
Loading

PR Summary

Replace string operations on char ones by using overloads like StartsWith(char) and EndsWith(char).

It speeds up path operations in filesystem provider and globbing.

PR Checklist

@iSazonov iSazonov added the Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality label Oct 19, 2018
@iSazonov iSazonov self-assigned this Oct 19, 2018
@anmenaga
Copy link

anmenaga commented Oct 30, 2018

I'm curious, what was the reason why Path Separator was a string (rather than a char)?

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Oct 30, 2018

@anmenaga .NET Framework only has overload for string, .NET Core added overload for char

@iSazonov iSazonov merged commit ecb467c into PowerShell:master Oct 31, 2018
@iSazonov iSazonov deleted the cleanup-defaultpathseparator branch October 31, 2018 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@anmenaga anmenaga Awaiting requested review from anmenaga

@BrucePay BrucePay Awaiting requested review from BrucePay

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels

Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @anmenaga @SteveL-MSFT @TravisEz13