-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Make S.M.A.PowerShell.GetSteppablePipeline method public #8055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make S.M.A.PowerShell.GetSteppablePipeline method public #8055
Conversation
|
Similar to the other PR I submitted earlier, I did not include test fixtures for this PR because I was not sure it needed any. If you want some added, please indicate where (Pester, or in a C# unit test). Thank you. |
|
Note: after this PR or #8056 are approved/merged, the other will have to be updated with the latest code and the Pester test that tests tab expansion and counts members on S.M.A.PowerShell will have to be updated (the count will increase by one). Just adding this comment so that I remember to update whichever of these isn't merged once the other one is so that there are no merge conflicts and all tests pass. |
|
@PowerShell/powershell-committee reviewed this and is ok making this public |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
|
This is not stale, it's just awaiting merge. |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Summary
PowerShell advanced function authors can create proxy functions in native PowerShell, but PowerShell cmdlet authors cannot create proxy cmdlets in native .NET. The S.M.A.PowerShell.GetSteppablePipeline() method is marked as internal, yet it is useful in both PowerShell and .NET when you want to work with proxy commands. This PR is simply to change the visibility of the GetSteppablePipeline method to public so that binary cmdlet authors don't need to use reflection to get access to this essential method.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests