Skip to content

Conversation

@KirkMunro
Copy link
Contributor

PR Summary

PowerShell advanced function authors can create proxy functions in native PowerShell, but PowerShell cmdlet authors cannot create proxy cmdlets in native .NET. The S.M.A.PowerShell.GetSteppablePipeline() method is marked as internal, yet it is useful in both PowerShell and .NET when you want to work with proxy commands. This PR is simply to change the visibility of the GetSteppablePipeline method to public so that binary cmdlet authors don't need to use reflection to get access to this essential method.

PR Checklist

@KirkMunro
Copy link
Contributor Author

Similar to the other PR I submitted earlier, I did not include test fixtures for this PR because I was not sure it needed any. If you want some added, please indicate where (Pester, or in a C# unit test). Thank you.

@iSazonov iSazonov added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Oct 17, 2018
@KirkMunro
Copy link
Contributor Author

Note: after this PR or #8056 are approved/merged, the other will have to be updated with the latest code and the Pester test that tests tab expansion and counts members on S.M.A.PowerShell will have to be updated (the count will increase by one). Just adding this comment so that I remember to update whichever of these isn't merged once the other one is so that there are no merge conflicts and all tests pass.

@SteveL-MSFT
Copy link
Member

@PowerShell/powershell-committee reviewed this and is ok making this public

@SteveL-MSFT SteveL-MSFT added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Nov 28, 2018
@stale
Copy link

stale bot commented Dec 29, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Dec 29, 2018
@KirkMunro
Copy link
Contributor Author

This is not stale, it's just awaiting merge.

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13 TravisEz13 merged commit 1729a68 into PowerShell:master Jan 9, 2019
@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 9, 2019
@KirkMunro KirkMunro deleted the make-getsteppablepipeline-public branch January 10, 2019 18:19
@sdwheeler sdwheeler modified the milestone: 6.2.0 Mar 25, 2019
@TravisEz13 TravisEz13 added this to the 6.3.0-preview.1 milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants