Skip to content

Allow creation of symlink to non-existent target #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andyleejordan merged 1 commit into from
Apr 10, 2016
Merged

Allow creation of symlink to non-existent target #804

andyleejordan merged 1 commit into from
Apr 10, 2016

Conversation

@andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Apr 10, 2016

This action is completely valid on both Windows and Linux (and OS X)
operating systems; tested with mklink and ln -s respectively.

Note that targets for hard links must exist, thus we check specifically
for symbolic links.

Both the path globber in session state and the New-Item implementation
needed to be fixed to allow the target not to exist.

Resolves #801.

This change is Reviewable

@andyleejordan
Allow creation of symlink to non-existent target
3a43126 
This action is completely valid on both Windows and Linux (and OS X)
operating systems; tested with `mklink` and `ln -s` respectively.

Note that targets for hard links must exist, thus we check specifically
for symbolic links.

Both the path globber in session state and the `New-Item` implementation
needed to be fixed to allow the target not to exist.

Resolves #801.

Also enable symbolic link tests on Windows.
@andyleejordan andyleejordan force-pushed the andschwa/symbolic-target branch from 2377094 to 3a43126 Compare April 10, 2016 01:45
@andyleejordan
Copy link
Member Author

andyleejordan commented Apr 10, 2016

FYI @LeeHolmes

@andyleejordan
Copy link
Member Author

andyleejordan commented Apr 10, 2016

Merging because I need this to make packages.

@andyleejordan andyleejordan merged commit 244b41a into master Apr 10, 2016
@andyleejordan andyleejordan deleted the andschwa/symbolic-target branch April 10, 2016 01:55
@vors
Copy link
Collaborator

vors commented Apr 11, 2016

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

test/powershell/New-Item.Tests.ps1, line 119 [r1] (raw file):
Please add a symlink test for a directory.

  1. Create non-existing
  2. Test ls on it
  3. Create matching dir
  4. Test ls again

test/powershell/New-Item.Tests.ps1, line 122 [r1] (raw file):
not sure that this is the right behavior

test/powershell/New-Item.Tests.ps1, line 128 [r1] (raw file):
How does somebody can figure out that this symlink is broken?

Comments from Reviewable

@andyleejordan
Copy link
Member Author

andyleejordan commented Apr 11, 2016

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

test/powershell/New-Item.Tests.ps1, line 119 [r1] (raw file):
Yeah that would be good to have. I'll add it to the backlog.

test/powershell/New-Item.Tests.ps1, line 122 [r1] (raw file):
This is the right behavior; the link file exists. If it didn't, this PR would be wrong.

test/powershell/New-Item.Tests.ps1, line 128 [r1] (raw file):
By testing the existence of its Target, as done here.

Comments from Reviewable

@andyleejordan andyleejordan mentioned this pull request Jan 5, 2017
Closed
@mklement0 mklement0 mentioned this pull request Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix creation of symbolic links to non-existing files

3 participants

@andyleejordan @vors