PowerShell · TravisEz13 · Oct 30, 2018 · Oct 15, 2018 · Oct 15, 2018 · Oct 16, 2018
diff --git a/docs/testing-guidelines/WritingPesterTests.md b/docs/testing-guidelines/WritingPesterTests.md
@@ -1,41 +1,41 @@
 ### Writing Pester Tests
+
 Note that this document does not replace the documents found in the [Pester](https://github.com/pester/pester "Pester") project.
 This is just some quick tips and suggestions for creating Pester tests for this project.
 The Pester community is vibrant and active, if you have questions about Pester or creating tests, the [Pester Wiki](https://github.com/pester/pester/wiki) has a lot of great information.
 As of January 2018, PowerShell Core is using Pester version 4 which has some changes from earlier versions.
 See [Migrating from Pester 3 to Pester 4](https://github.com/pester/Pester/wiki/Migrating-from-Pester-3-to-Pester-4) for more information.
 
-
-
 When creating tests, keep the following in mind:
 * Tests should not be overly complicated and test too many things
     * boil down your tests to their essence, test only what you need
 * Tests should be as simple as they can
 * Tests should generally not rely on any other test
 
 Examples:
-Here's the simplest of tests
+
+Here's the simplest of tests:
 
 ```powershell
 Describe "A variable can be assigned and retrieved" {
-    It "Create a variable and make sure its value is correct" {
+    It "Creates a variable and makes sure its value is correct" {
        $a = 1
-       $a | Should Be 1
+       $a | Should -Be 1
    }
 }
 ```
 
-If you need to do type checking, that can be done as well
+If you need to do type checking, that can be done as well:
 
 ```powershell
 Describe "One is really one" {
     It "Compare 1 to 1" {
        $a = 1
-       $a | Should Be 1
+       $a | Should -Be 1
     }
     It "1 is really an int" {
        $i = 1
-       $i.GetType() | Should Be "int"
+       $i.GetType() | Should -BeExactly "int"
     }
 }
 ```
@@ -46,11 +46,11 @@ alternatively, you could do the following:
 Describe "One is really one" {
     It "Compare 1 to 1" {
        $a = 1
-       $a | Should Be 1
+       $a | Should -Be 1
     }
     It "1 is really an int" {
        $i = 1
-       $i.GetType() | Should Be ([System.Int32])
+       $i | Should -BeOfType System.Int32
     }
 }
 ```
@@ -65,51 +65,60 @@ It "Get-Item on a nonexisting file should have error PathNotFound" {
 }
 ```
 
-Note that if Get-Item were to succeed, the test will fail.
+Note that if `Get-Item` were to succeed, the test will fail.
 
 However, if you need to check the `InnerException` or other members of the ErrorRecord, you should use `-PassThru` parameter:
 
 ```powershell
 	It "InnerException sample" {
 
 	$e = { Invoke-WebRequest https://expired.badssl.com/ } | Should -Throw -ErrorId "WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand" -PassThru
-	$e.Exception.InnerException.NativeErrorCode | Should Be 12175
+	$e.Exception.InnerException.NativeErrorCode | Should -Be 12175
     ...
 	}
 ```
 
 ### Describe/Context/It
-For creation of PowerShell tests, the Describe block is the level of granularity suggested and one of three tags should be used: "CI", "Feature", or "Scenario". If the tag is not provided, tests in that describe block will be run any time tests are executed.
+
+For creation of PowerShell tests, the `Describe` block is the level of granularity suggested and one of three tags should be used: "CI", "Feature", or "Scenario". If the tag is not provided, tests in that describe block will be run any time tests are executed.
 
 #### Describe
-Creates a logical group of tests. All Mocks and TestDrive contents defined within a Describe block are scoped to that Describe; they will no longer be present when the Describe block exits. A `Describe block may contain any number of Context and It blocks.
+
+Creates a logical group of tests.
+All `Mocks` and `TestDrive` contents defined within a `Describe` block are scoped to that `Describe`;
+they will no longer be present when the `Describe` block exits.
+A `Describe` block may contain any number of Context and `It` blocks.
 
 #### Context
-Provides logical grouping of It blocks within a single Describe block. Any Mocks defined inside a Context are removed at the end of the Context scope, as are any files or folders added to the TestDrive during the Context block's execution. Any BeforeEach or AfterEach blocks defined inside a Context also only apply to tests within that Context .
+
+Provides logical grouping of `It` blocks within a single `Describe` block. Any Mocks defined inside a `Context` are removed at the end of the `Context` scope, as are any files or folders added to the `TestDrive:` during the Context block's execution. Any `BeforeEach` or `AfterEach` blocks defined inside a `Context` also only apply to tests within that `Context`.
 
 #### It
-The  It  block is intended to be used inside of a  Describe  or  Context  Block. If you are familiar with the AAA pattern (Arrange-Act-Assert), the body of the  It  block is the appropriate location for an assert. The convention is to assert a single expectation for each  It  block. The code inside of the  It  block should throw a terminating error if the expectation of the test is not met and thus cause the test to fail. The name of the  It  block should expressively state the expectation of the test.
+
+The  `It` block is intended to be used inside of a `Describe` or `Context` block. If you are familiar with the AAA pattern (Arrange-Act-Assert), the body of the  `It`  block is the appropriate location for an assert. The convention is to assert a single expectation for each `It` block. The code inside of the `It` block should throw a terminating error if the expectation of the test is not met and thus cause the test to fail. The name of the `It` block should expressively state the expectation of the test.
 
 ### Admin privileges in tests
-Tests that require admin privileges **on windows** should be additionally marked with 'RequireAdminOnWindows' Pester tag.
+
+Tests that require admin privileges **on Windows** must be additionally marked with `RequireAdminOnWindows` Pester tag.
 In the AppVeyor CI, we run two different passes:
 
-- The pass with exclusion of tests with 'RequireAdminOnWindows' tag
-- The pass where we run only 'RequireAdminOnWindows' tests
+- The pass with exclusion of tests with `RequireAdminOnWindows` tag
+- The pass where we run only `RequireAdminOnWindows` tests
 
 In each case, tests are executed with appropriate privileges.
 
-Tests that need to be run with sudo **on Unix systems** should be additionally marked with 'RequireSudoOnUnix' Pester tag.
-'RequireSudoOnUnix' tag is mutually exclusive to all other tags like 'CI', 'Feature' etc. (which are now ignored when 'RequireSudoOnUnix' is present) and is treated as 'CI'.
+Tests that need to be run with sudo **on Unix systems** must be additionally marked with `RequireSudoOnUnix` Pester tag.
+`RequireSudoOnUnix` tag is mutually exclusive to all other tags like `CI`, `Feature` etc. (which are now ignored when `RequireSudoOnUnix` is present) and is treated as `CI`.
 Similarly as above, we run the tests in Travis CI in two passes:
-- With sudo only tests with 'RequireSudoOnUnix' tag
-- Without sudo all tests excluding those with 'RequireSudoOnUnix' tag.
+- With sudo only tests with `RequireSudoOnUnix` tag
+- Without sudo all tests excluding those with `RequireSudoOnUnix` tag.
 
 ### Selected Features
 
 #### Test Drive
-A PSDrive is available for file activity during a tests and this drive is limited to the scope of a single Describe block. The contents of the drive are cleared when a context block is exited.
-A test may need to work with file operations and validate certain types of file activities. It is usually desirable not to perform file activity tests that will produce side effects outside of an individual test. Pester creates a PSDrive inside the user's temporary drive that is accessible via a names PSDrive TestDrive:. Pester will remove this drive after the test completes. You may use this drive to isolate the file operations of your test to a temporary store.
+
+A `PSDrive` is available for file activity during a tests and this drive is limited to the scope of a single `Describe` block. The contents of the drive are cleared when a `Context` block is exited.
+A test may need to work with file operations and validate certain types of file activities. It is usually desirable not to perform file activity tests that will produce side effects outside of an individual test. Pester creates a `PSDrive` inside the user's temporary drive that is accessible via `TestDrive:` or `$TestDrive`. Pester will remove this drive after the test completes. You may use this drive to isolate the file operations of your test to a temporary store.
 
 The following example illustrates the feature:
 
@@ -130,7 +139,7 @@ Describe "Add-Footer" {
 }
 ```
 
-When this test completes, the contents of the TestDrive PSDrive will be removed.
+When this test completes, the contents of the `TestDrive:` `PSDrive` will be removed.
 
 #### Parameter Generation
 
@@ -145,28 +154,31 @@ $testCases = @(
 Describe "A test" {
     It "<a> -xor <b> should be <expectedresult>" -testcase $testcases {
         param ($a, $b, $ExpectedResult)
-        $a -xor $b | Should Be $ExpectedResult
+        $a -xor $b | Should -Be $ExpectedResult
     }
 }
 ```
 
 You can also construct loops and pass values as parameters, including the expected value, but Pester does this for you.
 
 #### Mocking
-Mocks the behavior of an existing command with an alternate implementation. This creates new behavior for any existing command within the scope of a Describe or Context block. The function allows you to specify a script block that will become the command's new behavior.
+
+Mocks the behavior of an existing command with an alternate implementation. This creates new behavior for any existing command within the scope of a `Describe` or `Context` block. The function allows you to specify a script block that will become the command's new behavior.
 The following example illustrates simple use:
 
 ```powershell
 Context "Get-Random is not random" {
         Mock Get-Random { return 3 }
         It "Get-Random returns 3" {
-            Get-Random | Should Be 3
+            Get-Random | Should -Be 3
         }
     }
 ```
 
 More information may be found on the [wiki](https://github.com/pester/Pester/wiki/Mock)
+
 ### Free Code in a Describe block
+
 Code execution in Pester can be very subtle and can cause issues when executing test code. The execution of code which lays outside of the usual code blocks may not happen as you expect. Consider the following:
 
 ```powershell
@@ -186,7 +198,7 @@ Describe it {
 
         Write-Host -for DarkRed "Before It"
         It "should not be a surprise" {
-            1 | should be 1
+            1 | should -Be 1
         }
         Write-Host -for DarkRed "After It"
     }
@@ -197,7 +209,7 @@ Describe it {
 }
 ```
 
-Now, when run, you can see the execution schedule
+Now, when run, you can see the execution schedule:
 
 ```
 PS# invoke-pester c:\temp\pester.demo.tests.ps1
@@ -223,10 +235,13 @@ Tests completed in 79ms
 Passed: 1 Failed: 0 Skipped: 0 Pending: 0
 ```
 
-The DESCRIBE BeforeAll block is executed before any other code even though it was at the bottom of the Describe block, so if state is set elsewhere in the describe BLOCK, that state will not be visible (as the code will not yet been run). Notice, too, that the BEFOREALL block in Context is executed before any other code in that block.
-Generally, you should have code reside in one of the code block elements of `[Before|After][All|Each]`, especially if those block rely on state set by free code elsewhere in the block.
+The `Describe` `BeforeAll` block is executed before any other code even though it was at the bottom of the `Describe` block,
+so if state is set elsewhere in the `Describe` block, that state will not be visible (as the code will not yet been run). Notice, too,
+that the `BeforeAll` block in `Context` is executed before any other code in that block.
+Generally, you should have code reside in one of the code block elements of `[Before|After][All|Each]`, especially if those blocks rely on state set by free code elsewhere in the block.
 
 #### Skipping tests in bulk
+
 Sometimes it is beneficial to skip all the tests in a particular `Describe` block. For example, tests which are not applicable to a platform could be skipped, and they would be reported as skipped. The following is an example of how this may be done:
 ```powershell
 Describe "Should not run these tests on non-Windows platforms" {
@@ -241,18 +256,18 @@ Describe "Should not run these tests on non-Windows platforms" {
     }
     Context "Block 1" {
         It "This block 1 test 1" {
-            1 | should be 1
+            1 | should -Be 1
         }
         It "This is block 1 test 2" {
-            1 | should be 1
+            1 | should -Be 1
         }
     }
     Context "Block 2" {
         It "This block 2 test 1" {
-            2 | should be 1
+            2 | should -Be 1
         }
         It "This is block 2 test 2" {
-            2 | should be 1
+            2 | should -Be 1
         }
     }
 }
@@ -277,25 +292,24 @@ Describing Should not run these tests on non-Windows platforms
     [-] This block 2 test 1 52ms
       Expected: {1}
       But was:  {2}
-      22:             2 | should be 1
+      22:             2 | should -Be 1
       at <ScriptBlock>, <No file>: line 22
     [-] This is block 2 test 2 77ms
       Expected: {1}
       But was:  {2}
-      25:             2 | should be 1
+      25:             2 | should -Be 1
       at <ScriptBlock>, <No file>: line 25
 ```
 
 this technique uses the `$PSDefaultParameterValues` feature of PowerShell to temporarily set the It block parameter `-skip` to true (or in the case of Windows, it is not set at all)
 
-
 #### Multi-line strings
 
 You may want to have a test like
 
 ```powershell
 It 'tests multi-line string' {
-    Get-MultiLineString | Should Be @'
+    Get-MultiLineString | Should -Be @'
 first line
 second line
 '@
@@ -307,10 +321,10 @@ The reason for it are line-ends.
 
 They cause problems for two reasons:
 
-* They are different on different platforms (`\r\n` on windows and `\n` on unix).
+* They are different on different platforms (`\r\n` on Windows and `\n` on Unix).
 * Even on the same system, they depends on the way how the repo was cloned.
 
-Particularly, in the default AppVeyour CI windows image, you will get `\n` line ends in all your files.
+Particularly, in the default AppVeyor CI Windows image, you will get `\n` line ends in all your files.
 That causes problems, because at runtime `Get-MultiLineString` would likely produce `\r\n` line ends on windows.
 
 Some workaround could be added, but they are sub-optimal and make reading test code harder.
@@ -322,7 +336,7 @@ function normalizeEnds([string]$text)
 }
 
 It 'tests multi-line string' {
-    normalizeEnds (Get-MultiLineString) | Should Be (normalizeEnds @'
+    normalizeEnds (Get-MultiLineString) | Should -Be (normalizeEnds @'
 first line
 second line
 '@)
@@ -339,11 +353,12 @@ Pester Do and Don't
 ===================
 
 ## Do
-1. Name your files <descriptivetest>.tests.ps1
-2. Keep tests simple
-    1. Test only what you need
-    2. Reduce dependencies
-3. Be sure to tag your `Describe` blocks based on their purpose
+
+1. Name your files `<descriptivetest>.tests.ps1`.
+2. Keep tests simple:
+    1. Test only what you need.
+    2. Reduce dependencies.
+3. Be sure to tag your `Describe` blocks based on their purpose:
     1. Tag `CI` indicates that it will be run as part of the continuous integration process. These should be unit test like, and generally take less than a second.
     2. Tag `Feature` indicates a higher level feature test (we will run these on a regular basis), for example, tests which go to remote resources, or test broader functionality
     3. Tag `Scenario` indicates tests of integration with other features (these will be run on a less regular basis and test even broader functionality than feature tests.
@@ -352,23 +367,24 @@ Pester Do and Don't
 5. Use `Context` to group tests
     1. Multiple `Context` blocks can help you group your test suite into logical sections
 6. Use `BeforeAll`/`AfterAll`/`BeforeEach`/`AfterEach` instead of custom initiators
-7. Prefer Try-Catch for expected errors and check $_.fullyQualifiedErrorId (don't use `should throw`)
+7. Prefer Try-Catch for expected errors and check `$_.fullyQualifiedErrorId` (don't use `should throw`).
 8. Use `-testcases` when iterating over multiple `It` blocks
 9. Use code coverage functionality where appropriate
 10. Use `Mock` functionality when you don't have your entire environment
 11. Avoid free code in a `Describe` block
     1. Use `[Before|After][Each|All]` see [Free Code in a Describe block](WritingPesterTests.md#free-code-in-a-describe-block)
-12. Avoid creating or using test files outside of TESTDRIVE:
-    1. TESTDRIVE: has automatic clean-up
+12. Avoid creating or using test files outside of `TESTDRIVE:`
+    1. `TESTDRIVE:` has automatic clean-up
 13. Keep in mind that we are creating cross platform tests
     1. Avoid using the registry
     2. Avoid using COM
 14. Avoid being too specific about the _count_ of a resource as these can change platform to platform
     1. ex: checking for the count of loaded format files, check rather for format data for a specific type
 
 ## Don't
-1. Don't have too many evaluations in a single It block
+
+1. Don't have too many evaluations in a single `It` block
     1. The first `Should` failure will stop that block
 2. Don't use `Should` outside of an `It` Block
 3. Don't use the word "Error" or "Fail" to test a positive case
-    1. ex: "Get-ChildItem TESTDRIVE: shouldn't fail", rather "Get-ChildItem should be able to retrieve file listing from TESTDRIVE"
+    1. ex: `"Get-ChildItem TESTDRIVE: shouldn't fail"`, rather than `"Get-ChildItem should be able to retrieve file listing from TESTDRIVE"`.