Add a path for checking ZoneInformation without throwing an exception #8025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Oct 15, 2018
iSazonov
reviewed
Oct 16, 2018
| string errorMessage = StringUtil.Format( | ||
| FileSystemProviderStrings.AlternateDataStreamNotFound, streamName, path); | ||
| throw new FileNotFoundException(errorMessage, resultPath); | ||
| throw new FileNotFoundException(errorMessage, $"{path}:{streamName.Trim()}"); |
Collaborator
There was a problem hiding this comment.
Do we really need Trim() for streamName in the internal methods? We do not this for path.
Collaborator
Author
There was a problem hiding this comment.
Not sure - I just opted to not change any functionality. Small cost on the error path.
Collaborator
There was a problem hiding this comment.
I vote to remove - I believe consumer should take care.
iSazonov
reviewed
Oct 17, 2018
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Oct 23, 2018
anmenaga
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In an effort to reduce the number of exceptions we throw as standard flowcontrol, this PR adds
as a non-throwing alternative to
CreateFileStream.This makes the code slightly faster and debugging slightly less annoying.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests