Fix static method invocation type inference #8018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
requested review from
BrucePay and
daxian-dbw
as code owners
Collaborator
Author
|
Looking into test failures. Also will move tests to the type inference section that I missed. Moving to WIP |
SeeminglyScience
changed the title
SeeminglyScience
changed the title
Collaborator
Author
|
Alright it's ready. I'm fairly certain that test failure isn't related, but if I'm wrong let me know and I'll look into it. |
Collaborator
|
@SeeminglyScience Seems test failure is related to your change. You could add a test from original Issue to TabCompletion.Tests.ps1 |
Collaborator
Author
|
Oh okay, I originally read the failure message backwards. It looks like the change catches an additional property that was previously missed. I'll change that test to include the missed property and a add test for the original example as well. |
lzybkr
approved these changes
Oct 16, 2018
iSazonov
approved these changes
Oct 16, 2018
Collaborator
|
@SeeminglyScience Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added handling for
PSMethodobjects inTryGetTypeFromMember. This fixes type inference for static method invocations (e.g.[powershell]::Create()).Resolves #7820
I wasn't able to find any tests for member completion so I added a few as well along with the test case for the resolved issue.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests