-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add Linux ARM64 build support #8016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Related to #7330 |
|
@slide Did you do any testing of the build? |
|
Is ARM64 also Raspbian? Should we update this doc to say both architectures of Raspbian? |
|
You also need to do some work if you want us to release a package (you could just file an issue for this, if that wasn't your intent.) The packaging module needs to be updated to be able to package TarArm64 PowerShell/tools/packaging/packaging.psm1 Line 68 in 81b67c9
Needs to be updated with a TarArm64 option And it needs to be called here: PowerShell/tools/releaseBuild/build.json Line 264 in 81b67c9
|
|
Yes, I tested on my RockPro64 board. I was using it to build ironpython on that board. I will also update the packaging, I was looking for that and didn't know where it was. |
|
My board is running Ubuntu 18.04 Bionic, not Raspian. |
|
How do I run the packaging stuff locally to test it out? |
|
run I did this from memory and start-pspackaging might tell you, that you need to skip release checks... It's fine to do that for development. If you only change the packaging code, you can just re-import the packaging module, and rerun the packaging step (this is why I separated the modules.) |
|
@slide What is status of the PR? Do you want to continue? |
|
Yes, I do, I just need to get back to it again. I'll try and do it this next week. |
|
restarted linux CI due to a connectivity issue |
|
I do still plan on getting back to this, if it needs to be closed for now for some reason, I can reopen at a later date if desired. |
|
I will not have time to get back to this for some time. Trying to get a local build of the package stuff has not been easy. |
|
@slide Thanks for starting this, I'll submit a new PR with the packaging work along with the changes you've made for the build |
|
I'll just re-use this PR |
|
@SteveL-MSFT - You need to add items suggest by comment #8016 (comment) |
|
@adityapatwardhan latest commit should address the rest of @TravisEz13 's feedback |
|
@slide Thank you for your contribution! |
PR Summary
This adds an additional flag to allow building for linux-arm64.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header]