Improve error message on non-Windows when importing clixml with securestring #7997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
force-pushed
the
deserialize-securestring-error
branch
2 times, most recently
from
250a304 to
0718f77
Compare
PaulHigin
approved these changes
Oct 11, 2018
Contributor
There was a problem hiding this comment.
"Deserialization of SecureString is currently only supported on Windows." ?
SteveL-MSFT
force-pushed
the
deserialize-securestring-error
branch
from
cbb8ef4 to
e0b5d1d
Compare
daxian-dbw
approved these changes
Oct 11, 2018
TravisEz13
approved these changes
Oct 12, 2018
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently, if you try to import clixml that contains a securestring, you get this error:
This dll is only available on Windows and causes confusion why it's not working. Change is to throw PlatformNotSupportedException on non-Windows.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests