Skip to content

Conversation

@VMCpp
Copy link
Contributor

@VMCpp VMCpp commented Oct 9, 2018

PR Summary

Simple grammatical correction in README.md file.

PR Checklist

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this PR provides much value. The current content is fine.

@anmenaga
Copy link

@SteveL-MSFT I actually think that PR provides more value than what is listed in the 'Files changes'. Something we discussed previously.

@SteveL-MSFT SteveL-MSFT dismissed their stale review October 10, 2018 21:55

Deferring to Andrew to review

@RDIL
Copy link
Contributor

RDIL commented Oct 10, 2018

I think this is the only one that makes more sense:

  • If you already cloned but forgot to use --recursive, you can update submodules manually:
  • If you have already cloned but forgot to use --recursive, you can update submodules manually:

To make things easy, you can just clone recursively:

```sh
git clone --recursive https://github.com/PowerShell/PowerShell.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--recursive is not needed anymore.

Do you want to fix this or merge as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like this to be removed as --recursive is not needed anymore.

@adityapatwardhan
Copy link
Member

@IgoTenz Please fill the PR template above, it helps us create change logs.

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 1, 2018

@adityapatwardhan I updated the PR description.

@TravisEz13 TravisEz13 merged commit c5c747c into PowerShell:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants