Removing aliases usages in build.psm1 #7964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting aliases to cmdlets in build.psm1
kvprasoon
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
bergmeister
approved these changes
Oct 7, 2018
Contributor
|
LGTM but not sure if the named parameters usage is a bit over the top |
iSazonov
approved these changes
Oct 8, 2018
Collaborator
|
@kvprasoon Please rebase to pass CIs. |
Contributor
|
@iSazonov Just re-queuing the build or making an empty commit should do the trick as well since PR builds are run in a PR branch, which is the forked branch as if it was already merged into master. |
TravisEz13
approved these changes
Oct 8, 2018
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting aliases to cmdlets in build.psm1
PR Summary
Converting aliases to cmdlets in build.psm1
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests