Skip to content

Conversation

@bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Oct 7, 2018

PR Summary

Upgrading to the latest official preview of .Net Core 2.2.
The update to 2.2 was applied everywhere except for the alpine docker image scripts as they need validation from the MSFT side beforehand.

PR Checklist

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 8, 2018

Perhaps worth the wait. It seems 2.2 branch inspired only by ASP.NET and EntityFramework changes.
Release 2.2.0 is expected in December and PowerShell release 6.2.0 in March. By this moment we will have a 2.2.1 service release. Also most of ordinary changes will be in 3.0 not in servicing releases and 2.2.

@bergmeister
Copy link
Contributor Author

bergmeister commented Oct 8, 2018

I don't mind if we keep the PR open for longer and accept a later preview or RTM version off .Net Core 2.2.
But I think it is good to have at least a point where we know everything is OK so that it is easier to upgrade later in case there are breaking changes in newer versions, I am happy to keep this branch up to date for the next weeks/months as a tracker for feasibility of an upgrade

@SteveL-MSFT
Copy link
Member

I'm ok with taking .NET Core 2.2 early in our 6.2-preview releases to make sure nothing obvious gets broken and any major issues gives .NET Core time to fix in 2.2.x

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 9, 2018

Preview3 is expected in weeks aspnet/Announcements#307.

TravisEz13
TravisEz13 previously approved these changes Oct 9, 2018
@TravisEz13
Copy link
Member

The changes look good. We are verifying with DotNet that 2.2 will be an LTS.

@TravisEz13 TravisEz13 self-assigned this Oct 9, 2018
@TravisEz13 TravisEz13 dismissed their stale review October 9, 2018 20:46

2.2 is not LTS

@TravisEz13
Copy link
Member

2.2 will not be an LTS. We should probably stay on 2.1 for now. At least until we discuss the impact of this. I like your changes to the xunit tests though. Would you mind submitting a separate PR for those? I can if you want me to.

…o netcore2.2

# Conflicts:
#	build.psm1
#	test/hosting/hosting.tests.csproj
@bergmeister bergmeister changed the title Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview2-26905-02 Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview3-27014-02 Oct 22, 2018
…ccore and sos due to the upgrade from preview2 to preview3
@SteveL-MSFT
Copy link
Member

We're having conversations with .NET Core team in terms of support alignment between PSCore6 and .NET Core. Until that gets resolved, we should only move to LTS versions of .NET Core.

@stale
Copy link

stale bot commented Nov 21, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Nov 21, 2018
@anmenaga
Copy link

@TravisEz13 Considering what you and @SteveL-MSFT wrote, we probably need to close this PR.

@stale stale bot removed the Stale label Nov 28, 2018
@iSazonov
Copy link
Collaborator

I see .Net Core 3.0 will come with tons changes, enhancement and additions. We may have to put a lot of effort into upgrading to this version. I think we can close the PR.

@bergmeister
Copy link
Contributor Author

Ok, agreed, I will close the PR but leave the branch in case anyone in the community is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants