-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview3-27014-02 #7961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… image creation process
…t (build number does not match sdk)
… to problems, they have stopped supporting it, therefore use dotnet test as an alternative xunit/xunit#1675 https://xunit.github.io/releases/2.4
|
Perhaps worth the wait. It seems 2.2 branch inspired only by ASP.NET and EntityFramework changes. |
|
I don't mind if we keep the PR open for longer and accept a later preview or RTM version off .Net Core 2.2. |
|
I'm ok with taking .NET Core 2.2 early in our 6.2-preview releases to make sure nothing obvious gets broken and any major issues gives .NET Core time to fix in 2.2.x |
|
Preview3 is expected in weeks aspnet/Announcements#307. |
|
The changes look good. We are verifying with DotNet that 2.2 will be an LTS. |
|
2.2 will not be an LTS. We should probably stay on 2.1 for now. At least until we discuss the impact of this. I like your changes to the xunit tests though. Would you mind submitting a separate PR for those? I can if you want me to. |
…o netcore2.2 # Conflicts: # build.psm1 # test/hosting/hosting.tests.csproj
…o netcore2.2 Conflicts auto-resolved by Tortoise-Git (white space problem only) # Conflicts: # assets/files.wxs
…ccore and sos due to the upgrade from preview2 to preview3
|
We're having conversations with .NET Core team in terms of support alignment between PSCore6 and .NET Core. Until that gets resolved, we should only move to LTS versions of .NET Core. |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
|
@TravisEz13 Considering what you and @SteveL-MSFT wrote, we probably need to close this PR. |
|
I see .Net Core 3.0 will come with tons changes, enhancement and additions. We may have to put a lot of effort into upgrading to this version. I think we can close the PR. |
|
Ok, agreed, I will close the PR but leave the branch in case anyone in the community is interested. |
PR Summary
Upgrading to the latest official preview of .Net Core 2.2.
The update to 2.2 was applied everywhere except for the alpine docker image scripts as they need validation from the MSFT side beforehand.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests