Skip to content

Allow dynamic parameter to be returned for Get-Content even if path matches nothing to get correct error #7957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 1 commit into from
Oct 18, 2018
Merged

Allow dynamic parameter to be returned for Get-Content even if path matches nothing to get correct error #7957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/System.Management.Automation/engine/SessionStateContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,7 @@ internal object GetContentReaderDynamicParameters(
out provider,
out providerInstance);

if (providerPaths.Count > 0)
{
// Get the dynamic parameters for the first resolved path

return GetContentReaderDynamicParameters(providerInstance, providerPaths[0], newContext);
}
return null;
return GetContentReaderDynamicParameters(providerInstance, path, newContext);
} // GetContentReaderDynamicParameters

/// <summary>
Expand Down
9 changes: 9 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Get-Content.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,15 @@ baz
} | Should -Throw -ErrorId "InvalidOperation,Microsoft.PowerShell.Commands.GetContentCommand"
}

It "Should throw ItemNotFound when path matches no files with <variation>" -TestCases @(
@{ variation = "no additional parameters"; params = @{} },
@{ variation = "dynamic parameter" ; params = @{ Raw = $true }}
) {
param($params)

{ Get-Content -Path "/DoesNotExist*.txt" @params -ErrorAction Stop } | Should -Throw -ErrorId "ItemNotFound,Microsoft.PowerShell.Commands.GetContentCommand"
}

Context "Check Get-Content containing multi-byte chars" {
BeforeAll {
$firstLine = "Hello,World"
Expand Down