Skip to content

Add dependencies for SUSE #7938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Oct 3, 2018
Merged

Add dependencies for SUSE #7938

TravisEz13 merged 1 commit into from
Oct 3, 2018

Conversation

@Jellyfrog
Copy link
Contributor

@Jellyfrog Jellyfrog commented Oct 3, 2018

PR Summary

Adds correct dependencies for the SUSE rpm

PR Checklist

@TravisEz13
Copy link
Member

TravisEz13 commented Oct 3, 2018

We don't build a package for Open SUSE. Our guidance is to use the tar.gz or Snap. https://docs.snapcraft.io/core/install . https://snapcraft.io/powershell
But, I'm happy to merge this if you want to build your own packages.

@TravisEz13 TravisEz13 self-assigned this Oct 3, 2018
@Jellyfrog
Copy link
Contributor Author

Jellyfrog commented Oct 3, 2018

We don't build a package for Open SUSE. Our guidance is to use the tar.gz or Snap. https://docs.snapcraft.io/core/install . https://snapcraft.io/powershell
But, I'm happy to merge this if you want to build your own packages.

I added it because there are already a couple of places that checks for IsSUSEFamily, and the offical(?) documentation says to use the RHEL version; https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-linux?view=powershell-6#opensuse-423
So I thought this could be useful!

@TravisEz13 TravisEz13 merged commit 8f6bbdf into PowerShell:master Oct 3, 2018
@Jellyfrog Jellyfrog deleted the patch-1 branch October 3, 2018 19:30
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@Jellyfrog @TravisEz13
Add dependencies for SUSE (PowerShell#7938)
ec5aa2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jellyfrog @TravisEz13 @adityapatwardhan