fix the "Basic cookbooks" link #7934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a mistake on the PowerShell Web Docs: Basic cookbooks link, but searching on the documentation, the only link that mention "cookbook is the suggested. It's right? Is any file missing?
Contributor
Author
|
It's right? Is any file missing? |
iSazonov
reviewed
Oct 3, 2018
docs/learning-powershell/README.md
Outdated
| - Microsoft Virtual Academy: [Getting Started with PowerShell][getstarted-with-powershell] | ||
| - [Why Learn PowerShell][why-learn-powershell] by Ed Wilson | ||
| - PowerShell Web Docs: [Basic cookbooks][basic-cookbooks] | ||
| - PowerShell Web Docs: [Basic cookbooks][https://docs.microsoft.com/en-us/powershell/scripting/getting-started/fundamental/sample-scripts-for-administration?view=powershell-6] |
Collaborator
There was a problem hiding this comment.
Please use the file pattern and move the url to eof (add [basic-cookbooks]:url).
iSazonov
approved these changes
Oct 3, 2018
Collaborator
|
Appveyor CI temporary failed. |
Contributor
Author
|
@iSazonov how can I help to solve the AppVeyor error? |
Member
|
@vmsilvamolina I restarted build on AppVeyor as it's not related to your changes |
Member
|
I had to restart AppVeyor again. Ping me if I don't update the PR within a day. |
|
@TravisEz13 This looks ready for merge. |
Collaborator
|
@vmsilvamolina Thanks for your contribution! |
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I found a mistake on the PowerShell Web Docs: Basic cookbooks link, but searching on the documentation, the only link that mention "cookbook", is the suggested.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests