Make Add-Type open source files with FileAccess.Read and FileShare.Read explicitly #7915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitting the `FileAccess` attribute when constructing a `FileStream` with `FileMode.Open` makes the constructor default to `FileAccess.ReadWrite`, which is completely unecessary and inappropriate for Add-Type when compiling from source
IISResetMe
changed the title
iSazonov
approved these changes
Oct 2, 2018
Collaborator
|
@IISResetMe Please update package versions. (It is not your issue but our test system requirement.) |
IISResetMe
requested review from
TravisEz13,
adityapatwardhan and
anmenaga
as code owners
Collaborator
Author
|
@iSazonov done, not sure why the |
TravisEz13
approved these changes
Oct 2, 2018
Member
|
Restarted AppVeyor |
iSazonov
changed the title
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7914
Omitting the
FileAccessattribute when constructing aFileStreamwithFileMode.Openmakes the constructor default toFileAccess.ReadWrite, which is completely unecessary and inappropriate for Add-Type when compiling from sourcePR Summary
This PR ensures that Add-Type explicitly opens source code files with only Read access
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests