Skip to content

Remove clone args #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 3 commits into from
Oct 29, 2018
Merged

Remove clone args #7910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28b3ff1
Remove dumb code
iSazonov Oct 1, 2018
ae7154f
Remove unneeded args cloning
iSazonov Oct 1, 2018
d0d0300
[Feature]
iSazonov Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,6 @@ internal static int Start(

try
{
string[] tempArgs = new string[args.GetLength(0)];
args.CopyTo(tempArgs, 0);

// We might be able to ignore console host creation error if we are running in
// server mode, which does not require a console.
HostException hostException = null;
Expand All @@ -163,16 +160,11 @@ internal static int Start(
hostException = e;
}

if (args == null)
Copy link
Member

@TravisEz13 TravisEz13 Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably leave the null check in the code.

Copy link
Collaborator Author

@iSazonov iSazonov Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is c# convention that args is never null?

{
args = new string[0];
}

s_cpp = new CommandLineParameterParser(
(s_theConsoleHost != null) ? s_theConsoleHost.UI : (new NullHostUserInterface()),
bannerText, helpText);

s_cpp.Parse(tempArgs);
s_cpp.Parse(args);

#if UNIX
// On Unix, logging has to be deferred until after command-line parsing
Expand Down