Update installpsh amazonlinux for container build #7907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarwinJS
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
Collaborator
|
@DarwinJS Please rebase to get latest commit and add more information in description. |
TravisEz13
approved these changes
Oct 1, 2018
Member
|
@DarwinJS Did you look at the CodeFactor issues? |
…ttps://github.com/DarwinJS/PowerShell into update-installpsh-amazonlinux-for-container-build
Contributor
Author
|
@TravisEz13 - I did look at the issues - seems like a lot of refactoring to cleanup long standing syntax. I would like to just get this small update worked in without touching that much code if that is ok? |
Member
bmanikm
approved these changes
Oct 2, 2018
Member
|
I restarted all CI's |
|
@TravisEz13 @adityapatwardhan This looks ready for merge. |
adityapatwardhan
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #7906 - add packages tar and gzip so that install will work on amazon linux 2 container image which has minimal packages
Fix #7903 - change "if" to "fi"
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests