Fix Enter-PSSession -ContainerId for newest Windows
#7883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck for new type and fall back to old type
iSazonov
reviewed
Sep 28, 2018
src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs
Show resolved
Hide resolved
PaulHigin
suggested changes
Oct 1, 2018
src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs
Show resolved
Hide resolved
SteveL-MSFT
force-pushed
the
enter-pssession-container
branch
from
9dd69f3 to
db88f4b
Compare
daxian-dbw
reviewed
Oct 9, 2018
src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs
Outdated
Show resolved
Hide resolved
daxian-dbw
approved these changes
Oct 9, 2018
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
…#7883) Hyper-V team changed the type used to get the `runtimeid`. We need to check for new type and fall back to old type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The code tries to retrieve the runtimeid of the container, but Hyper-V team changed the type name (namespace) and from a property to a field. To support older Windows, we first check for the new type and then fallback to checking for the old type.
Fix #5794
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests