Skip to content

Optimize Images! #7874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 7 commits into from
Oct 1, 2018
Merged

Optimize Images! #7874

TravisEz13 merged 7 commits into from
Oct 1, 2018

Conversation

@RDIL
Copy link
Contributor

@RDIL RDIL commented Sep 26, 2018 •
edited
Loading

PR Summary

My pal @ImgBotApp optimized all the images present in the repository.

PR Checklist

  • [PR has a meaningful title]
  • [Summarized changes]
  • [Change is not breaking]
  • [Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header]
  • This PR is ready to merge and is not [Work in Progress]
  • Testing - New and feature
    • Can be tested right away

ImgBotApp and others added 2 commits September 26, 2018 21:50
@ImgBotApp
[ImgBot] optimizes images
2fc7cc8 
*Total -- 1,173.92kb -> 884.45kb (24.66%)

/.github/Images/GitHub-PR.png -- 13.15kb -> 7.83kb (40.44%)
/docs/testing-guidelines/Images/CoverageReportTop.PNG -- 440.22kb -> 325.20kb (26.13%)
/docs/testing-guidelines/Images/CoverageReportFilter.PNG -- 593.63kb -> 446.84kb (24.73%)
/docs/maintainers/Images/squash-merge.png -- 38.18kb -> 31.10kb (18.55%)
/docs/maintainers/Images/merge-commit.png -- 37.32kb -> 30.40kb (18.53%)
/docs/maintainers/Images/merge-commit-confirm.png -- 22.17kb -> 18.16kb (18.1%)
/docs/maintainers/Images/squash-confirm.png -- 24.58kb -> 20.26kb (17.54%)
/test/powershell/Modules/Microsoft.PowerShell.Security/TestData/CatalogTestData/TestImage.gif -- 4.68kb -> 4.66kb (0.6%)
@RDIL
Merge pull request #1 from RDIL/imgbot
87ebb15 
[ImgBot] optimize images
@msftclas
Copy link

msftclas commented Sep 26, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@RDIL
Copy link
Contributor Author

RDIL commented Sep 26, 2018

why did PowerShell-CI-linux — #PR-7874-20180926.01 fail :(

@RDIL
Copy link
Contributor Author

RDIL commented Sep 26, 2018

Wait that's not my code thats failing

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 27, 2018

@RDIL Please rebase to get latest commits and pass CIs.

@RDIL
Merge pull request #2 from PowerShell/master
d379a30 
Add 'TimeToLive' and 'Hops' aliases to MaxHops parameter of Test-Conn…
@RDIL
Copy link
Contributor Author

RDIL commented Sep 27, 2018

I think I did it...

@RDIL
Copy link
Contributor Author

RDIL commented Sep 27, 2018

That’s odd, some checks are still failing :(

@RDIL
Copy link
Contributor Author

RDIL commented Sep 27, 2018

Test failures:
Description: NewFileCatalogForFilesThatDoNotSupportEmbeddedSignatures
4037Name: Test suite for NewFileCatalogAndTestFileCatalogCmdlets.NewAndTestCatalogTests PositiveTestCases when validation Succeeds.NewFileCatalogForFilesThatDoNotSupportEmbeddedSignatures
4038message:
4039Expected strings to be the same, but they were different.
4040String lengths are both 40.
4041Strings differ at index 0.
4042Expected: {B0E4B9F0BB21284AA0AF0D525C913420AD73DA6A}
4043But was: {C1FCC65488C1DFF7F0D7C5F85F3091433AF09BBF}
4044-----------^
4045stack-trace:
4046at , C:\projects\powershell\test\powershell\Modules\Microsoft.PowerShell.Security\FileCatalog.Tests.ps1: line 30
404730: $keyValue1 | Should -Be $keyValue2
40481 tests in test/powershell failed
4049if ($env:Purpose -eq 'ElevatedPesterTests_xUnit_Packaging'){ Invoke-AppveyorFinish }

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 27, 2018 •
edited
Loading

@RDIL Please revert the file test/powershell/Modules/Microsoft.PowerShell.Security/TestData/CatalogTestData/TestImage.gif

It is used in our tests.

@RDIL
Copy link
Contributor Author

RDIL commented Sep 28, 2018

@iSazonov done!

@RDIL
Merge new commits from PowerShell/master
c485364 
Merge newer commits from main powershell repo
@RDIL
Copy link
Contributor Author

RDIL commented Sep 29, 2018

...

@TravisEz13 TravisEz13 merged commit bc4575f into PowerShell:master Oct 1, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 2, 2018

@RDIL Thanks for your contribution!

@RDIL
Copy link
Contributor Author

RDIL commented Oct 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RDIL @msftclas @iSazonov @TravisEz13 @ImgBotApp