Test changes needed for running in a container #7869

JamesWTruher · 2018-09-26T17:17:33Z

PR Summary

These are changes which will enable our tests to be run within containers for the 9 different Linux platforms that we provide. In order to successfully run in a container an environment variable __InContainer must be present to avoid running the help test which starts a browser. The best place to define this variable is in the Dockerfile, ala:
ENV __InContainer 1

Additionally, these tests may be executed against the already installed PowerShell.

This is the first step in completely automating our tests against packaged (rather than built) PowerShell.

PR Checklist

adityapatwardhan · 2018-09-26T17:19:43Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

typo raher -> rather

adityapatwardhan · 2018-09-26T17:20:18Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

Use Where-Object instead

adityapatwardhan · 2018-09-26T17:20:44Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

typo InternNetworkV6 -> InterNetworkV6

adityapatwardhan · 2018-09-26T17:21:17Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

Use ForEach-Object instead

adityapatwardhan · 2018-09-26T17:22:29Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

typo in -> if

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

adityapatwardhan · 2018-09-26T17:27:33Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

Can you double check if this still needs to be maked as Pending. It worked on my Ubuntu 18.04 VM.

it's definitely failing on my mac, I'll mark it pending for $IsMacOS

adityapatwardhan · 2018-09-26T17:27:45Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

Same as above.

adityapatwardhan · 2018-09-26T17:29:41Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

Can you remove this comment?

Please remove comment if it does not hang in VSTS.

adityapatwardhan · 2018-09-26T17:30:49Z

test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1

Where is this defined?

Please add a comment about $env:__InContainer

The code to open help in a browser is pretty simple. Perhaps rather than skipping these tests in non-desktop environments, we should instead have a test hook to validate that it hit the right code path or even start a test executable passed the URL as an argument?

there is a test hook here already, and it is used to validate all the uris. This is a single test which starts the browser.

I'm ok with this for now

adityapatwardhan · 2018-09-27T18:02:02Z

test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1

Please add a comment about $env:__InContainer

adityapatwardhan · 2018-09-27T18:02:41Z

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

Please remove comment if it does not hang in VSTS.

adityapatwardhan · 2018-09-27T18:15:24Z

@JamesWTruher Please also have a look at the test failure in CI for Linux and MacOS.

Also please push a commit with [Feature] to run all tests.

adityapatwardhan · 2018-09-27T20:31:23Z

@JamesWTruher Test-Connection test is failing on Linux and macOS with Exception calling "GetHostEntry" with "1" argument(s): "No such device or address"

Also please push a commit with [Feature]

SteveL-MSFT · 2018-09-27T20:49:24Z

test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1

The code to open help in a browser is pretty simple. Perhaps rather than skipping these tests in non-desktop environments, we should instead have a test hook to validate that it hit the right code path or even start a test executable passed the URL as an argument?

JamesWTruher · 2018-09-27T22:57:01Z

@SteveL-MSFT please see my comment above re: starting a browser

make the `MTUSizeDetect` tests pending for MacOS only.

JamesWTruher assigned adityapatwardhan Sep 26, 2018

JamesWTruher requested review from TravisEz13 and adityapatwardhan September 26, 2018 17:17

adityapatwardhan requested changes Sep 26, 2018

View reviewed changes

adityapatwardhan requested changes Sep 27, 2018

View reviewed changes

Test changes needed for running in a container

17ebbf5

JamesWTruher force-pushed the containertestfixes branch from c6b7e71 to 2efd9bd Compare September 27, 2018 18:21

SteveL-MSFT requested changes Sep 27, 2018

View reviewed changes

JamesWTruher force-pushed the containertestfixes branch from 2efd9bd to b670ede Compare September 27, 2018 22:37

SteveL-MSFT approved these changes Sep 27, 2018

View reviewed changes

[feature] Fix a number of typos

c7d0f7a

make the `MTUSizeDetect` tests pending for MacOS only.

JamesWTruher force-pushed the containertestfixes branch from b670ede to c7d0f7a Compare September 28, 2018 17:07

adityapatwardhan approved these changes Sep 28, 2018

View reviewed changes

adityapatwardhan merged commit 98cf44c into PowerShell:master Sep 28, 2018

JamesWTruher deleted the containertestfixes branch September 23, 2023 05:34

Test changes needed for running in a container #7869

Test changes needed for running in a container #7869

Uh oh!

Conversation

JamesWTruher commented Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented Sep 27, 2018

Uh oh!

adityapatwardhan commented Sep 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher commented Sep 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JamesWTruher commented Sep 26, 2018 •

edited

Loading