Skip to content

Add 'TimeToLive' and 'Hops' aliases to MaxHops parameter of Test-Connection cmdlet. #7850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 7 commits into from
Sep 27, 2018
Merged

Add 'TimeToLive' and 'Hops' aliases to MaxHops parameter of Test-Connection cmdlet. #7850

iSazonov merged 7 commits into from
Sep 27, 2018

Conversation

@sethvs
Copy link
Contributor

@sethvs sethvs commented Sep 23, 2018 •
edited
Loading

PR Summary

Fix #7849

Add the following aliases to MaxHops parameter of Test-Connection cmdlet:

TimeToLive
It is the similar parameter's name from Windows PowerShell Test-Connection cmdlet .

Hops
Similar parameter's name from Test-NetConnection cmdlet.

Fix MaxHops parameter summary.

PR Checklist

@sethvs
Copy link
Contributor Author

sethvs commented Sep 23, 2018

Hm. I haven't touched NJsonSchema.

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 26, 2018

@sethvs Please update NJsonSchema package version. It is not related to the PR but it come from our new common test.

@iSazonov iSazonov self-assigned this Sep 26, 2018
@sethvs
Copy link
Contributor Author

sethvs commented Sep 26, 2018

Should I update Markdig.Signed Version?

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 26, 2018

Feel free to update.

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Sep 26, 2018

@sethvs instead of updating the ref versions, you should just rebase against upstream master which has those fixed

@anmenaga
Copy link

anmenaga commented Sep 26, 2018

@adityapatwardhan is it something that requires "User-facing Documentation needed"
or alternative aliases will be automatically included in the help?

@sethvs sethvs requested a review from BrucePay as a code owner September 26, 2018 18:10
@sethvs
Copy link
Contributor Author

sethvs commented Sep 26, 2018

@SteveL-MSFT Rebased.

@sethvs
Copy link
Contributor Author

sethvs commented Sep 26, 2018

@anmenaga The help for PowerShell Core 6.1 Test-Connection now is almost similar to Windows PowerShell 5.1 Test-Connection. It should be massively reworked.

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Sep 26, 2018

@anmenaga Yes, we need to file an issue according to the template for updating the docs.

This was referenced Sep 26, 2018
Closed
Merged
@sethvs
Copy link
Contributor Author

sethvs commented Sep 26, 2018

@anmenaga @adityapatwardhan Created issue and PR in powershell-Docs repo.

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 27, 2018

@sethvs The PR still contains other's commits. Please rebase properly.

@sethvs
Copy link
Contributor Author

sethvs commented Sep 27, 2018

@iSazonov Done.

@iSazonov iSazonov merged commit 2291a89 into PowerShell:master Sep 27, 2018
@sethvs sethvs deleted the testConnection branch September 27, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@BrucePay BrucePay Awaiting requested review from BrucePay

Assignees

@iSazonov iSazonov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 'TimeToLive' and 'Hops' aliases to MaxHops parameter of Test-Connection cmdlet.

5 participants

@sethvs @iSazonov @SteveL-MSFT @anmenaga @adityapatwardhan