Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Sep 21, 2018

PR Summary

update markdown tests

  • explicitly use gulp 4.0 beta because 3.9 depends on a vulnerable package

PR Checklist

@TravisEz13 TravisEz13 requested a review from rjmholt September 21, 2018 21:37
Copy link
Collaborator

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but it's non-blocking.

Otherwise, LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary change, or should we just take the if-statement out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this change. It was to allow local testing of the change.

@TravisEz13 TravisEz13 force-pushed the update_markdown_tests branch from 6693515 to 87b70eb Compare September 21, 2018 22:29
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

Import-Module HelpersCommon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoloading should works.

@TravisEz13 TravisEz13 merged commit 8a0abf4 into PowerShell:master Sep 24, 2018
@TravisEz13 TravisEz13 deleted the update_markdown_tests branch September 24, 2018 17:14
@TravisEz13 TravisEz13 added the WG-Quality-Test issues in a test or in test infrastructure label Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WG-Quality-Test issues in a test or in test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants