Update to .NET Core 2.1.4 with SDK 2.1.402 #7834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
iSazonov
iSazonov
approved these changes
Sep 21, 2018
anmenaga
reviewed
Sep 21, 2018
assets/files.wxs
Outdated
There was a problem hiding this comment.
@TravisEz13 does the Id on these has to be re-generated? (to be unique for servicing purposes)
Member
There was a problem hiding this comment.
either the ID or the Guid of the component need to change. Can you not make the change manually and use the file that Start-PSPackage generates and tells you to use?
Member
Author
|
@TravisEz13 You comment is addressed. Please take another look, thanks. |
11 tasks
TravisEz13
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update to .NET Core 2.1.4 with SDK 2.1.402
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests