Skip to content

Update PowerShellGet to 2.0.0 #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 2 commits into from
Sep 24, 2018
Merged

Update PowerShellGet to 2.0.0 #7831

adityapatwardhan merged 2 commits into from
Sep 24, 2018

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Sep 20, 2018 •
edited
Loading

PR Summary

Update version of PowerShellGet to 2.0.0

PR Checklist

@anmenaga
Copy link

anmenaga commented Sep 20, 2018 •
edited
Loading

I think @TravisEz13 mentioned to me that there is some functionality in VSTS to detect these things (updated dependency versions)...

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Sep 20, 2018

PackageManagement tests are part of Feature tests. Please push an empty commit with [Feature].

@TravisEz13
Copy link
Member

TravisEz13 commented Sep 20, 2018

It looks like the PowerShellGet tests need to be updated.

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Sep 20, 2018

@bmanikm can you look at the test failures?

@daxian-dbw
Copy link
Member

daxian-dbw commented Sep 21, 2018

The Package Reference from package.tests.ps1 fails because NJsonSchema updates the revision number again. The revision number is incremented about every week.

I updated to the latest review in PR #7834. At the same time, we need to think about how to not get interrupted too much by this special package.

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Sep 21, 2018

@daxian-dbw should we special case NJsonSchema to only look at major.minor?

@bmanikm
Copy link
Contributor

bmanikm commented Sep 21, 2018

@SteveL-MSFT I have updated the PowerShellGet tests, it looks like the new test failures are not related to PowerShellGet, please take a look at the new test failures.

@TravisEz13 TravisEz13 self-assigned this Sep 21, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Sep 21, 2018

rebased the PR to pick up fixes for test failures

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Sep 24, 2018

Rebase and pushed to update package references.

@adityapatwardhan adityapatwardhan merged commit 769ba7b into PowerShell:master Sep 24, 2018
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 14, 2019
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@TravisEz13
Get PowerShellGet tests working (PowerShell#7831)
34f0ddf
@SteveL-MSFT SteveL-MSFT deleted the psget-20 branch March 10, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+1 more reviewer

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

@adityapatwardhan adityapatwardhan

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SteveL-MSFT @anmenaga @adityapatwardhan @TravisEz13 @daxian-dbw @bmanikm