Adding fxdependent PS package tests #7830
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| FROM centos:7 | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN yum install -y \ | ||
| glibc-locale-source \ | ||
| git | ||
|
|
||
| # Install dotnet-runtime | ||
| RUN rpm -Uvh https://packages.microsoft.com/config/rhel/7/packages-microsoft-prod.rpm | ||
| RUN yum install -y \ | ||
|
Member
There was a problem hiding this comment. This wont be needed if using the 2.1-sdk or 2.1-runtime image is used.
Author
There was a problem hiding this comment. Updated base image for ubuntu18.04 and debian.9; |
||
| dotnet-runtime-2.1 | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN localedef --charmap=UTF-8 --inputfile=en_US $LANG | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| FROM debian:jessie | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| apt-utils \ | ||
| ca-certificates \ | ||
| apt-transport-https \ | ||
| locales \ | ||
| git \ | ||
| wget | ||
|
Member
There was a problem hiding this comment. don't add |
||
|
|
||
| # Install dotnet-runtime | ||
|
Member
There was a problem hiding this comment. This might not be needed.
Author
There was a problem hiding this comment. I didn't find .NET image for debian.8 |
||
| RUN wget -qO- https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.asc.gpg | ||
| RUN mv microsoft.asc.gpg /etc/apt/trusted.gpg.d/ | ||
| ADD https://packages.microsoft.com/config/debian/8/prod.list . | ||
| RUN mv prod.list /etc/apt/sources.list.d/microsoft-prod.list | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| dotnet-runtime-2.1 | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN locale-gen $LANG && update-locale | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| FROM microsoft/dotnet:2.1-runtime-stretch-slim | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| apt-utils \ | ||
| ca-certificates \ | ||
| apt-transport-https \ | ||
| locales \ | ||
| git | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN locale-gen $LANG && update-locale | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| FROM fedora:27 | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN dnf install -y \ | ||
| glibc-locale-source \ | ||
| git \ | ||
| compat-openssl10 \ | ||
| && dnf upgrade-minimal -y --security \ | ||
| && dnf clean all | ||
|
|
||
| # Install dotnet-runtime | ||
| RUN rpm --import https://packages.microsoft.com/keys/microsoft.asc | ||
| ADD https://packages.microsoft.com/config/fedora/27/prod.repo . | ||
| RUN mv prod.repo /etc/yum.repos.d/microsoft-prod.repo | ||
| RUN dnf install -y \ | ||
| dotnet-runtime-2.1 \ | ||
| && dnf upgrade-minimal -y --security \ | ||
| && dnf clean all | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN localedef --charmap=UTF-8 --inputfile=en_US $LANG | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| FROM fedora:28 | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN dnf install -y \ | ||
| glibc-locale-source \ | ||
| git \ | ||
| compat-openssl10 \ | ||
| && dnf upgrade-minimal -y --security \ | ||
| && dnf clean all | ||
|
|
||
| # Install dotnet-runtime | ||
| RUN rpm --import https://packages.microsoft.com/keys/microsoft.asc | ||
| ADD https://packages.microsoft.com/config/fedora/27/prod.repo . | ||
| RUN mv prod.repo /etc/yum.repos.d/microsoft-prod.repo | ||
| RUN dnf install -y \ | ||
| dotnet-runtime-2.1 \ | ||
| && dnf upgrade-minimal -y --security \ | ||
| && dnf clean all | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN localedef --charmap=UTF-8 --inputfile=en_US $LANG | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| FROM opensuse:42.2 | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN zypper --non-interactive update --skip-interactive \ | ||
| && zypper --non-interactive install \ | ||
| glibc-locale \ | ||
| glibc-i18ndata \ | ||
| tar \ | ||
| libunwind \ | ||
| libicu \ | ||
| openssl \ | ||
| git | ||
|
|
||
| # Install dotnet-runtime | ||
| RUN rpm --import https://packages.microsoft.com/keys/microsoft.asc | ||
| ADD https://packages.microsoft.com/config/opensuse/42.2/prod.repo . | ||
| RUN mv prod.repo /etc/zypp/repos.d/microsoft-prod.repo | ||
| RUN zypper --non-interactive update --skip-interactive \ | ||
| && zypper --non-interactive install \ | ||
| dotnet-runtime-2.1 | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN localedef --charmap=UTF-8 --inputfile=en_US $LANG | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| FROM opensuse:42.3 | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN zypper --non-interactive update --skip-interactive \ | ||
| && zypper --non-interactive install \ | ||
| glibc-locale \ | ||
| glibc-i18ndata \ | ||
| tar \ | ||
| libunwind \ | ||
| libicu \ | ||
| openssl \ | ||
| git | ||
|
|
||
| # Install dotnet-runtime | ||
| RUN rpm --import https://packages.microsoft.com/keys/microsoft.asc | ||
| ADD https://packages.microsoft.com/config/opensuse/42.2/prod.repo . | ||
| RUN mv prod.repo /etc/zypp/repos.d/microsoft-prod.repo | ||
| RUN zypper --non-interactive update --skip-interactive \ | ||
| && zypper --non-interactive install \ | ||
| dotnet-runtime-2.1 | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN localedef --charmap=UTF-8 --inputfile=en_US $LANG | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| FROM ubuntu:trusty | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| apt-utils \ | ||
| ca-certificates \ | ||
| apt-transport-https \ | ||
| locales \ | ||
| git | ||
|
|
||
| # Install dotnet-runtime | ||
| ADD https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb . | ||
| RUN dpkg -i packages-microsoft-prod.deb | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| dotnet-runtime-2.1 | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN locale-gen $LANG && update-locale | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| FROM ubuntu:xenial | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| apt-utils \ | ||
| ca-certificates \ | ||
| apt-transport-https \ | ||
| locales \ | ||
| git | ||
|
|
||
| # Install dotnet-runtime | ||
| ADD https://packages.microsoft.com/config/ubuntu/16.04/packages-microsoft-prod.deb . | ||
| RUN dpkg -i packages-microsoft-prod.deb | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| dotnet-runtime-2.1 | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN locale-gen $LANG && update-locale | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| FROM microsoft/dotnet:2.1-runtime-bionic | ||
|
|
||
| ARG PACKAGENAME | ||
| ARG PACKAGELOCATION | ||
| ARG PREVIEWSUFFIX= | ||
| ARG TESTLIST=/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module | ||
| ARG TESTDOWNLOADCOMMAND="git clone --recursive https://github.com/PowerShell/PowerShell.git" | ||
|
|
||
| # Install dependencies | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| apt-utils \ | ||
| ca-certificates \ | ||
| apt-transport-https \ | ||
| locales \ | ||
| git | ||
|
|
||
| # Setup the locale | ||
| ENV LANG en_US.UTF-8 | ||
| ENV LC_ALL $LANG | ||
| RUN locale-gen $LANG && update-locale | ||
|
|
||
| # Install PowerShell package | ||
| ADD $PACKAGELOCATION/$PACKAGENAME . | ||
| RUN mkdir -p /opt/microsoft/powershell | ||
| RUN tar zxf $PACKAGENAME -C /opt/microsoft/powershell | ||
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should base this off the 2.1-runtime and 2.1-sdk image flavors from https://hub.docker.com/r/microsoft/dotnet/tags/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this for ubuntu18.04 and debian.9;
Unfortunately they don't have any other images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to test all these platforms?