Adding fxdependent PS package tests #7830
Conversation
|
|
||
| # Download and run tests | ||
| RUN $TESTDOWNLOADCOMMAND | ||
| RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount" No newline at end of file |
There was a problem hiding this comment.
missing newline at end of the file
| @@ -0,0 +1,32 @@ | |||
| FROM centos:7 | |||
There was a problem hiding this comment.
We should base this off the 2.1-runtime and 2.1-sdk image flavors from https://hub.docker.com/r/microsoft/dotnet/tags/
There was a problem hiding this comment.
Updated this for ubuntu18.04 and debian.9;
Unfortunately they don't have any other images.
There was a problem hiding this comment.
Do we need to test all these platforms?
| apt-transport-https \ | ||
| locales \ | ||
| git \ | ||
| wget |
There was a problem hiding this comment.
don't add wget, use the docker ADD commande
|
|
||
| # Install dependencies | ||
| RUN yum install -y \ | ||
| curl \ |
There was a problem hiding this comment.
Don't add curl, see comments about wget
|
|
||
| # Install dotnet-runtime | ||
| RUN rpm -Uvh https://packages.microsoft.com/config/rhel/7/packages-microsoft-prod.rpm | ||
| RUN yum install -y \ |
There was a problem hiding this comment.
This wont be needed if using the 2.1-sdk or 2.1-runtime image is used.
There was a problem hiding this comment.
Updated base image for ubuntu18.04 and debian.9;
Unfortunately .NET doesn't have any other images.
| git \ | ||
| wget | ||
|
|
||
| # Install dotnet-runtime |
There was a problem hiding this comment.
This might not be needed.
There was a problem hiding this comment.
I didn't find .NET image for debian.8
|
@TravisEz13 @adityapatwardhan please take a look again. |
|
@TravisEz13 Please have another look. |
|
@anmenaga Can you have a look at the CodeFactor issues? |
|
@TravisEz13 @anmenaga There are issues reported by CodeFactor for Docker files. Should they be resolved? |
|
As far as I can tell, All the docker issues from CodeFactor are false positives. |
3 participants
PR Summary
Fix #7750
fxdependent package = .NET framework dependent PowerShell package.
It is is a small-footprint (~22 MB) PowerShell package that can be run on a machine where dotnet runtime is installed separately. Requirement for having such package is driven by .NET team.
This PR adds release-time tests for fxdependent package for all currently supported Linux configurations.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests