Get/Add-Content throws improved error when targeting a container #7823
Conversation
|
@iSazonov I think more rules are added to CodeFactor, issues are in untouched lines. |
There was a problem hiding this comment.
We need another message for "write" cmdlets.
There was a problem hiding this comment.
Added different error message for Write to container exception.
There was a problem hiding this comment.
Please remove obvious comment.
There was a problem hiding this comment.
Please remove obvious comment.
There was a problem hiding this comment.
I'd prefer {0} on end of the string because we support long paths.
Unable to write content because it is a directory: {0}For GetContainerContentException too.
/cc @SteveL-MSFT
There was a problem hiding this comment.
Sure, that makes sense.
There was a problem hiding this comment.
I think the updated error messages are fine, even for GetContainerContentException.
|
The package validation on NJsonSchema is a known issue not related to this PR |
|
Reopen the PR to restart all CIs. |
|
@kvprasoon can you rebase off master to pick up test fixes? |
Get/Add-Content throws improved error when targeting a container
CodeFactor Fix
Review comments changes
Error message changes as per review comments,
|
@kvprasoon I rebased for you. Further please create new branch in your fork for every new change (don't put commits in forked master). |
|
@iSazonov Sure, will do it, learning OSS collaboration from each PR... thanks |
3 participants
PR Summary
Fix #7770
Fix #2686
Enhancing the error message as per #7770 and #2686
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests