Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Sep 18, 2018

PR Summary

The current README.md has badges showing the status of build of master branch, but this reflects the last submitted PR which is temporal. Depending on when you load the page, someone could have a broken build in an un-merged PR. This is not actionable from the README.md as the PR submitted would be fixing it in their PR. This row of badges is more confusing than helpful.

Fix is to remove that row of badges. Only the nightly badges are useful which are post PR merges.

PR Checklist

@TravisEz13
Copy link
Member

#7817 will workaround the failure in linux CI

@TravisEz13
Copy link
Member

I rebased tho branch to pickup the CI fix from #7817

@TravisEz13 TravisEz13 merged commit 985c238 into PowerShell:master Sep 19, 2018
@SteveL-MSFT SteveL-MSFT deleted the remove-master-badges branch March 10, 2020 21:01
@xtqqczze
Copy link
Contributor

@SteveL-MSFT this PR left a few orphan link definitions, e.g. [az-windows-image], PR #12656 removes all unused link definitions from markdown files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants