Fix .NET adapter to be able to get members from System.IntPtr #7808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
https://powershell.visualstudio.com/PowerShell/_build/results?buildId=1979&view=logs |
iSazonov
reviewed
Sep 18, 2018
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Member.Tests.ps1
Outdated
Show resolved
Hide resolved
Collaborator
|
PowerShell-CI-Linux issue is in many PRs :-( |
iSazonov
approved these changes
Sep 19, 2018
|
@TravisEz13 fixed |
Member
Author
|
Clicking 'details' on the Linux-CI gives me |
TravisEz13
approved these changes
Sep 19, 2018
Member
|
I started a rebuild of the linux CI. You may need to rebase. The error indicates you code is out of date. |
Member
|
Yes, you need to rebase. |
Member
Author
|
Rebased. Will wait on the CIs. |
Member
Author
|
@iSazonov Thanks for merging this PR. Just a gentle reminder: when squashing a PR, check the commit title to make sure unneeded tags are removed, such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix .NET adapter to be able to get members from
System.IntPtr.The type
System.IntPtrhas an explicit cast operator defined that takes a pointer typeSystem.void*parameter. We didn't handle that type properly inGetPSMethodProjectedType.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests