Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Sep 15, 2018

PR Summary

Update build badges to use Azure Pipeline Badges and links

  • I also formatted tables

PR Checklist

Copy link
Contributor

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point, the .vsts-ci would need renaming to azure pipelines as well (but this would also be a breaking change for the build definitions that would need updating then, which could complicate patch releases)

@TravisEz13
Copy link
Member Author

@bergmeister If you want to rename the directory, please go ahead. It won't affect our release process, but please mention me as I'll have to update the build definition is Azure Pipelines to point to the new location.

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment.

| AppVeyor (Windows) | Travis CI (Linux) | Travis CI (macOS) | Code Coverage Status | Code Factor Status |
|--------------------------|-------------------|-------------------|----------------------|--------------------|
| [![av-nightly-image][]][av-nightly-site] | [![linux-nightly-image][]][tv-site] | [![macOS-nightly-image][]][tv-site] | [![cc-image][]][cc-site] | [![cf-image][]][cf-site] |
| AppVeyor (Windows) | Azure CI (Linux) | Azure CI (macOS) | Code Coverage Status | Code Factor Status |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: maybe just Azure (Linux) and Azure (macOS) without CI? CI was from Travis CI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be making more edits. We can change this later.

@TravisEz13 TravisEz13 merged commit 2d4906c into PowerShell:master Sep 17, 2018
@TravisEz13 TravisEz13 deleted the update_unix_daily_badges branch September 17, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants