Ensure the SSHClientSessionTransportManager stream writer and reader fields are cleared after dispose. #7746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix possible race conditions accessing the fields during CloseConnection.
dantraMSFT
requested review from
PaulHigin,
TravisEz13,
adityapatwardhan and
daxian-dbw
and removed request for
PaulHigin and
mirichmo
iSazonov
approved these changes
Sep 10, 2018
PaulHigin
reviewed
Sep 10, 2018
Contributor
PaulHigin
left a comment
PaulHigin
left a comment
There was a problem hiding this comment.
LGTM, but this shouldn't be necessary. From Microsoft documentation:
"If an object's Dispose method is called more than once, the object must ignore all calls after the first one. The object must not throw an exception if its Dispose method is called multiple times. Instance methods other than Dispose can throw an ObjectDisposedException when resources are already disposed."
PaulHigin
reviewed
Sep 10, 2018
PaulHigin
approved these changes
Sep 10, 2018
Collaborator
|
@PaulHigin I guess that Dispose() should support a protection |
TravisEz13
pushed a commit
that referenced
this pull request
Sep 10, 2018
…r fields are cleared after dispose. (#7746) Fix possible race conditions accessing the fields during CloseConnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7740
PR Summary
Fix the ObjectDisposedException in SSHClientSessionTransportManager.CloseConnection calling StreamWriter.Dispose multiple times.
There are two changes:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests