Add daily build non-windows platforms #7683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
Member
Author
|
Linux build with |
Member
Author
|
macos build with |
Collaborator
|
@TravisEz13 Have you already considered running the tests with a bot like CoreFX team does? This is more convenient than add |
adityapatwardhan
requested changes
Sep 4, 2018
tools/travis.ps1
Outdated
Member
There was a problem hiding this comment.
the format should be yyyyMMddhhmm ss is for seconds.
tools/travis.ps1
Outdated
Member
There was a problem hiding this comment.
Could you add an comment about FORCE_FEATURE and FORCE_PACKAGE
TravisEz13
force-pushed
the
add_daily_build_non_windows
branch
4 times, most recently
from
9afc198 to
0be0cd6
Compare
TravisEz13
force-pushed
the
add_daily_build_non_windows
branch
6 times, most recently
from
975745d to
18cfb8f
Compare
TravisEz13
changed the title
TravisEz13
force-pushed
the
add_daily_build_non_windows
branch
from
6ec80f5 to
2f72688
Compare
TravisEz13
force-pushed
the
add_daily_build_non_windows
branch
from
2f72688 to
aa6b242
Compare
TravisEz13
changed the title
Member
Author
|
@adityapatwardhan your issues have been addressed as well as codefactor and the test issues |
adityapatwardhan
requested changes
Sep 6, 2018
.vsts-ci/windows.yml
Outdated
| - powershell: Write-Host "##vso[build.updatebuildnumber]$env:BUILD_SOURCEBRANCHNAME-$env:BUILD_SOURCEVERSION-$((get-date).ToString("yyyyMMddhhss"))" | ||
| - powershell: | | ||
| Get-ChildItem -Path env: | ||
| displayName: Capture envirenment |
|
|
||
| tempPipeline.Output.DataReady += new EventHandler(OutputObjectStreamHandler); | ||
| tempPipeline.Error.DataReady += new EventHandler(ErrorObjectStreamHandler); | ||
| PipelineFinishedWaitHandle waiterThereIsAFlyInMySoup = new PipelineFinishedWaitHandle(tempPipeline); |
Member
There was a problem hiding this comment.
Please change name of the variable.
tools/travis.ps1
Outdated
| # If the current job is a pull request, the env variable 'TRAVIS_PULL_REQUEST_SHA' contains | ||
| # the commit SHA of the HEAD commit of the PR. | ||
| $commitMessage = git log --format=%B -n 1 $commitId | ||
| Write-Verbose "commitMessage: $commitMessage" -verbose |
Member
There was a problem hiding this comment.
Should Write-Log be used here instead?
tools/travis.ps1
Outdated
| # Run a full build if the build was trigger via cron, api or the commit message contains `[Feature]` | ||
| $hasFeatureTag = $commitMessage -match '\[feature\]' | ||
| $hasPackageTag = $commitMessage -match '\[package\]' | ||
| # or the environment valiable `FORCE_FEATURE` equals `True` |
adityapatwardhan
approved these changes
Sep 6, 2018
SteveL-MSFT
approved these changes
Sep 6, 2018
TravisEz13
added a commit
that referenced
this pull request
Sep 7, 2018
Add daily build non-windows platforms - Also, make the [Feature] tag work in VSTS for non-windows - Also, add a way to force feature tests to run - Also, fix an issue where `-workingdirectory` didn't work when running async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add daily build non-windows platforms
Branched from #7658 as the windows CI is taking a long time to work out the test issues
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests