Skip to content

Add daily build non-windows platforms - #7683

Merged
Travis Plunk (TravisEz13) merged 15 commits into
PowerShell:masterfrom
TravisEz13:add_daily_build_non_windows
Sep 6, 2018
Merged

Travis Plunk (TravisEz13) merged 15 commits into
PowerShell:masterfrom
TravisEz13:add_daily_build_non_windows

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Aug 31, 2018 •

Copy link
Copy Markdown
Member

PR Summary

Add daily build non-windows platforms

  • Also, make the [Feature] tag work in VSTS for non-windows
  • Also, add a way to force feature tests to run
  • Also, fix an issue where -workingdirectory didn't work when running async

Branched from #7658 as the windows CI is taking a long time to work out the test issues

PR Checklist

@TravisEz13

Copy link
Copy Markdown
Member Author

@TravisEz13

Copy link
Copy Markdown
Member Author

macos build with FORCE_FEATURE=True https://powershell.visualstudio.com/PowerShell/_build/results?buildId=1246

@iSazonov

Ilya (iSazonov) commented Sep 3, 2018 •

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Have you already considered running the tests with a bot like CoreFX team does? This is more convenient than add [Feature].

Comment thread tools/travis.ps1 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the format should be yyyyMMddhhmm ss is for seconds.

Comment thread tools/travis.ps1 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an comment about FORCE_FEATURE and FORCE_PACKAGE

@TravisEz13
Travis Plunk (TravisEz13) force-pushed the add_daily_build_non_windows branch 6 times, most recently from 975745d to 18cfb8f Compare September 5, 2018 20:59
@TravisEz13 Travis Plunk (TravisEz13) changed the title Add daily build non-windows platforms WIP: Add daily build non-windows platforms Sep 5, 2018
@TravisEz13 Travis Plunk (TravisEz13) changed the title WIP: Add daily build non-windows platforms Add daily build non-windows platforms Sep 6, 2018
@TravisEz13

Copy link
Copy Markdown
Member Author

Aditya Patwardhan (@adityapatwardhan) your issues have been addressed as well as codefactor and the test issues

Comment thread .vsts-ci/windows.yml Outdated
- powershell: Write-Host "##vso[build.updatebuildnumber]$env:BUILD_SOURCEBRANCHNAME-$env:BUILD_SOURCEVERSION-$((get-date).ToString("yyyyMMddhhss"))"
- powershell: |
Get-ChildItem -Path env:
displayName: Capture envirenment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo environment

@@ -194,6 +206,13 @@ internal void ExecuteCommandAsyncHelper(Pipeline tempPipeline, out Exception exc
tempPipeline.Error.DataReady += new EventHandler(ErrorObjectStreamHandler);
PipelineFinishedWaitHandle waiterThereIsAFlyInMySoup = new PipelineFinishedWaitHandle(tempPipeline);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change name of the variable.

Comment thread tools/travis.ps1 Outdated
# If the current job is a pull request, the env variable 'TRAVIS_PULL_REQUEST_SHA' contains
# the commit SHA of the HEAD commit of the PR.
$commitMessage = git log --format=%B -n 1 $commitId
Write-Verbose "commitMessage: $commitMessage" -verbose

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Write-Log be used here instead?

Comment thread tools/travis.ps1 Outdated
# Run a full build if the build was trigger via cron, api or the commit message contains `[Feature]`
$hasFeatureTag = $commitMessage -match '\[feature\]'
$hasPackageTag = $commitMessage -match '\[package\]'
# or the environment valiable `FORCE_FEATURE` equals `True`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo variable

@TravisEz13
Travis Plunk (TravisEz13) merged commit 2141c2a into PowerShell:master Sep 6, 2018
@TravisEz13
Travis Plunk (TravisEz13) deleted the add_daily_build_non_windows branch September 6, 2018 19:27
Travis Plunk (TravisEz13) added a commit that referenced this pull request Sep 7, 2018
Add daily build non-windows platforms
  - Also, make the [Feature] tag work in VSTS for non-windows
  - Also, add a way to force feature tests to run
  - Also, fix an issue where `-workingdirectory` didn't work when running async
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Sep 7, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Add daily build non-windows platforms
  - Also, make the [Feature] tag work in VSTS for non-windows
  - Also, add a way to force feature tests to run
  - Also, fix an issue where `-workingdirectory` didn't work when running async
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Add daily build non-windows platforms
  - Also, make the [Feature] tag work in VSTS for non-windows
  - Also, add a way to force feature tests to run
  - Also, fix an issue where `-workingdirectory` didn't work when running async
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants