Fix file blocking issue with webcmdlets #7676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claustn
requested review from
JamesWTruher,
PaulHigin and
dantraMSFT
as code owners
iSazonov
changed the title
Collaborator
|
@Claustn Thanks! I slightly corrected the PR title and description. |
iSazonov
approved these changes
Aug 31, 2018
Collaborator
|
@Claustn Please rename your commit - start title with |
Collaborator
|
CI Appveyor temporary failed. |
markekraus
reviewed
Aug 31, 2018
Contributor
markekraus
left a comment
markekraus
left a comment
There was a problem hiding this comment.
LGTM. My approval is pending successful completion of all [feature] tests.
Claustn
force-pushed
the
fix/webcmdlets_infile_blocking
branch
from
c32a3a5 to
5f70274
Compare
Collaborator
|
@Claustn Thanks for discovering the issue and fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Resolve #7669.
Allows multiple uploads of the same file in parallel
This PR changes how -InFile parameter on the Web cmdlets open file handles. Previously the file was opened with ShareAccess None, meaning that the file was locked, resulting in that you, for instance, was not able to upload the same file to multiple destinations in parallel.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests