WIP: Add VSTS daily and feature tag support #7658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
adityapatwardhan
approved these changes
Aug 29, 2018
TravisEz13
force-pushed
the
add_daily_builds
branch
7 times, most recently
from
1a7a660 to
744a301
Compare
TravisEz13
changed the title
11 tasks
TravisEz13
force-pushed
the
add_daily_builds
branch
from
8c52ca2 to
b23ec26
Compare
TravisEz13
force-pushed
the
add_daily_builds
branch
2 times, most recently
from
d4c77d9 to
1659030
Compare
daxian-dbw
reviewed
Sep 17, 2018
build.psm1
Outdated
Member
There was a problem hiding this comment.
This comment seems not complete.
Member
|
@adityapatwardhan mentioned running all tests for PRs. If we go with that, then we won't be needing the tags. |
TravisEz13
force-pushed
the
add_daily_builds
branch
6 times, most recently
from
2c6cfc3 to
31debca
Compare
remove code to wait on process 1. it was causing issues 2. the calling code waits shorten timeout Add timeout when running as non-admin Don't switch to non-admin user on AppVeyor give everyone full access to the buffer file/folder use non-admin user to run tests Create non-admin user
TravisEz13
force-pushed
the
add_daily_builds
branch
from
31debca to
86f0854
Compare
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
Member
Author
|
I will come back to this. |
Member
Author
|
This was merged as #8220 . Thank @PaulHigin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add VSTS daily and feature tag support
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests