Cleanup FileSystemProvider from runtime checks #7655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace runtime checks with compile time checks. Remove unneeded methods.
Collaborator
Author
|
:-) I wonder that my first all-in-one commit failed and I had to split on steps. |
rjmholt
approved these changes
Aug 29, 2018
Collaborator
rjmholt
left a comment
rjmholt
left a comment
There was a problem hiding this comment.
This looks good to me -- much nicer!
| } | ||
|
|
||
| #endif | ||
| return InternalGetTarget(fileSysInfo.FullName); |
Collaborator
There was a problem hiding this comment.
I see the definition for this method is gone but a call remains. Is there another definition somewhere?
Collaborator
Author
There was a problem hiding this comment.
Yes, one - wih handle parameter, second with string parameter. First one was removed.
|
@daxian-dbw can you please review this? Thanks. @iSazonov please do a |
daxian-dbw
approved these changes
Sep 8, 2018
2 tasks
TravisEz13
pushed a commit
that referenced
this pull request
Sep 10, 2018
Replace runtime checks with compile time checks. Remove unneeded methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Address second part of #2349
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests