Skip to content

Remove SuspendJob and ResumeJob cmdlets from compilation #7650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Aug 30, 2018
Merged

Remove SuspendJob and ResumeJob cmdlets from compilation #7650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45e25d
Remove SuspendJob and ResumeJob sources from compilation
JamesWTruher Aug 28, 2018
5e3c50a
Move 'compile remove' statements out of exclusion from Non-Windows to…
JamesWTruher Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/System.Management.Automation/System.Management.Automation.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@
<Compile Remove="engine\TransactionManager.cs" />
<Compile Remove="engine\hostifaces\NativeCultureResolver.cs" />
<Compile Remove="engine\hostifaces\RunspaceInvoke.cs" />
<Compile Remove="engine\remoting\commands\ResumeJob.cs" />
<Compile Remove="engine\remoting\commands\SuspendJob.cs" />
<Compile Remove="logging\eventlog\EventLogLogProvider.cs" />
<Compile Remove="namespaces\SafeTransactionHandle.cs" />
<Compile Remove="namespaces\SafeRegistryHandle.cs" />
Expand Down Expand Up @@ -132,12 +134,12 @@
<ItemGroup Condition=" '$(IsWindows)' != 'true' ">
<Compile Remove="engine\ExtraAdapter.cs" />
<Compile Remove="engine\ManagementObjectAdapter.cs" />
<Compile Remove="engine\remoting\commands\ReceivePSSession.cs" />
<Compile Remove="engine\remoting\commands\DisconnectPSSession.cs" />
<Compile Remove="engine\remoting\commands\ConnectPSSession.cs" />
<Compile Remove="engine\remoting\commands\CustomShellCommands.cs" />
Copy link
Member

@adityapatwardhan adityapatwardhan Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ItemGroup is specific to non-windows. I think we need to remove these for all platforms

Copy link
Collaborator Author

@JamesWTruher JamesWTruher Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely should be all platforms to remove.
fixed

<Compile Remove="engine\remoting\commands\DisconnectPSSession.cs" />
<Compile Remove="engine\remoting\commands\EnterPSHostProcessCommand.cs" />
<Compile Remove="engine\remoting\commands\NewPSSessionOptionCommand.cs" />
<Compile Remove="engine\remoting\commands\CustomShellCommands.cs" />
<Compile Remove="engine\remoting\commands\ReceivePSSession.cs" />
<Compile Remove="engine\remoting\commands\TestPSSessionConfigurationFile.cs" />
</ItemGroup>

Expand Down