Remove SuspendJob and ResumeJob cmdlets from compilation #7650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
JamesWTruher
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
dantraMSFT
as code owners
JamesWTruher
changed the title
adityapatwardhan
requested changes
Aug 28, 2018
| <Compile Remove="engine\remoting\commands\ReceivePSSession.cs" /> | ||
| <Compile Remove="engine\remoting\commands\DisconnectPSSession.cs" /> | ||
| <Compile Remove="engine\remoting\commands\ConnectPSSession.cs" /> | ||
| <Compile Remove="engine\remoting\commands\CustomShellCommands.cs" /> |
Member
There was a problem hiding this comment.
The ItemGroup is specific to non-windows. I think we need to remove these for all platforms
Collaborator
Author
There was a problem hiding this comment.
definitely should be all platforms to remove.
fixed
… exclusion for all
adityapatwardhan
approved these changes
Aug 28, 2018
TravisEz13
approved these changes
Aug 29, 2018
dantraMSFT
approved these changes
Aug 30, 2018
daxian-dbw
approved these changes
Aug 30, 2018
TravisEz13
pushed a commit
that referenced
this pull request
Aug 31, 2018
The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
This can be taken for 6.2, there is no reason to take it for 6.1
PR Summary
Remove SuspendJob and ResumeJob from compilation
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests